Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/commands/show_signin_command.h

Issue 2254813002: Remove SignInSource from ShowSigninCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@signin_source
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/signin/constants.h ('k') | ios/chrome/browser/ui/commands/show_signin_command.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/commands/show_signin_command.h
diff --git a/ios/chrome/browser/ui/commands/show_signin_command.h b/ios/chrome/browser/ui/commands/show_signin_command.h
index efc415980e056760392eacf5762531af47ab07c9..70651268196c9cfd9eb45bf67dd048fbcbd8a797 100644
--- a/ios/chrome/browser/ui/commands/show_signin_command.h
+++ b/ios/chrome/browser/ui/commands/show_signin_command.h
@@ -8,7 +8,6 @@
#import <Foundation/Foundation.h>
#include "components/signin/core/browser/signin_metrics.h"
-#include "ios/chrome/browser/signin/constants.h"
#include "ios/chrome/browser/ui/commands/generic_chrome_command.h"
typedef void (^ShowSigninCommandCompletionCallback)(BOOL succeeded);
@@ -36,22 +35,12 @@ enum AuthenticationOperation {
// Initializes a command to perform the specified operation with a
// SigninInteractionController and invoke a possibly-nil callback when finished.
- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInSource:(SignInSource)signInSource
+ signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
callback:(ShowSigninCommandCompletionCallback)callback
NS_DESIGNATED_INITIALIZER;
// Initializes a ShowSigninCommand with a nil callback.
- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInSource:(SignInSource)signInSource;
-
-// Initializes a command to perform the specified operation with a
-// SigninInteractionController and invoke a possibly-nil callback when finished.
-- (instancetype)initWithOperation:(AuthenticationOperation)operation
- signInAccessPoint:(signin_metrics::AccessPoint)signInAccessPoint
- callback:(ShowSigninCommandCompletionCallback)callback;
-
-// Initializes a ShowSigninCommand with a nil callback.
-- (instancetype)initWithOperation:(AuthenticationOperation)operation
signInAccessPoint:
(signin_metrics::AccessPoint)signInAccessPoint;
@@ -61,9 +50,6 @@ enum AuthenticationOperation {
// The operation to perform during the sign-in flow.
@property(nonatomic, readonly) AuthenticationOperation operation;
-// The source of this authentication operation.
-@property(nonatomic, readonly) SignInSource signInSource;
-
// The access point of this authentication operation.
@property(nonatomic, readonly) signin_metrics::AccessPoint signInAccessPoint;
« no previous file with comments | « ios/chrome/browser/signin/constants.h ('k') | ios/chrome/browser/ui/commands/show_signin_command.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698