Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup (Closed)

Created:
6 years, 8 months ago by kinuko
Modified:
6 years, 8 months ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: propagate provider_id to the browser process in .register Remotely for event/object rewiring. This also fixes all int32 used in IPC for in-memory object IDs to int BUG=349919 TEST=no functional changes yet Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262973

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -52 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 2 chunks +8 lines, -0 lines 1 comment Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 2 10 chunks +10 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 7 chunks +28 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 2 4 chunks +10 lines, -8 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 2 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
Separated a cleanup/mechanical part from http://crrev.com/201303004. I'd like to land this part separately to avoid ...
6 years, 8 months ago (2014-04-07 09:29:43 UTC) #1
Tom Sepez
Why is changing int32 to the less-specific int required?
6 years, 8 months ago (2014-04-07 18:33:13 UTC) #2
kinuko
On 2014/04/07 18:33:13, Tom Sepez wrote: > Why is changing int32 to the less-specific int ...
6 years, 8 months ago (2014-04-08 12:14:52 UTC) #3
michaeln
lgtm > PTL, mechanical changes only > > michaeln@ (or someone in the team): service_worker/* ...
6 years, 8 months ago (2014-04-08 16:09:23 UTC) #4
Tom Sepez
Messages LGTM.
6 years, 8 months ago (2014-04-08 17:22:51 UTC) #5
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 8 months ago (2014-04-10 08:41:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/225403014/60001
6 years, 8 months ago (2014-04-10 08:41:43 UTC) #7
commit-bot: I haz the power
Change committed as 262973
6 years, 8 months ago (2014-04-10 13:50:27 UTC) #8
Jeffrey Yasskin
6 years, 8 months ago (2014-04-11 23:21:23 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/225403014/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_context_core.cc (right):

https://codereview.chromium.org/225403014/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_context_core.cc:91:
ServiceWorkerProviderHost* provider_host,
Note that ServiceWorkerJobCoordinator::Unregister doesn't currently use the
source_process_id: 
https://code.google.com/p/chromium/codesearch/#chromium/src/content/browser/s...
Could you double-check that it's actually going to use the ProviderHost?

Powered by Google App Engine
This is Rietveld 408576698