Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index e6dc32f23807b94d0734c35b0110e0d0b4ebc4e0..2d2e830de81ed227f277e6f9d6d0d0d14d54887f 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -69,9 +69,13 @@ void ServiceWorkerContextCore::RegisterServiceWorker(
const GURL& pattern,
const GURL& script_url,
int source_process_id,
+ ServiceWorkerProviderHost* provider_host,
const RegistrationCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ // TODO(kinuko): Wire the provider_host so that we can tell which document
+ // is calling .register.
+
job_coordinator_->Register(
pattern,
script_url,
@@ -84,9 +88,13 @@ void ServiceWorkerContextCore::RegisterServiceWorker(
void ServiceWorkerContextCore::UnregisterServiceWorker(
const GURL& pattern,
int source_process_id,
+ ServiceWorkerProviderHost* provider_host,
Jeffrey Yasskin 2014/04/11 23:21:24 Note that ServiceWorkerJobCoordinator::Unregister
const UnregistrationCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ // TODO(kinuko): Wire the provider_host so that we can tell which document
+ // is calling .register.
+
job_coordinator_->Unregister(pattern, source_process_id, callback);
}

Powered by Google App Engine
This is Rietveld 408576698