content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.cc ('K') | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 2adb94b92870ca736e5e7d9da0315510c0f518cd..8a407eff05ef0604dea3f10257d4646b0ab92d39 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -89,7 +89,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, DisabledCausesError) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);

@@ -116,7 +116,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, DISABLED_Enabled) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);

base::RunLoop().RunUntilIdle();

@@ -144,7 +144,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, EarlyContextDeletion) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);