content/child/service_worker/web_service_worker_provider_impl.cc - Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.cc

Issue 225403014: ServiceWorker: propagate provider_id to the browser process in .register + int32/int cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.cc ('K') | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_provider_impl.cc

diff --git a/content/child/service_worker/web_service_worker_provider_impl.cc b/content/child/service_worker/web_service_worker_provider_impl.cc

index af8c9c99cda43f65d40de4d77108a3fc32d20d8f..5ddd47e27dff47918fb1f1a275edd907306a887c 100644

--- a/content/child/service_worker/web_service_worker_provider_impl.cc

+++ b/content/child/service_worker/web_service_worker_provider_impl.cc

@@ -39,13 +39,15 @@ void WebServiceWorkerProviderImpl::registerServiceWorker(

const WebURL& pattern,

const WebURL& script_url,

WebServiceWorkerCallbacks* callbacks) {

- GetDispatcher()->RegisterServiceWorker(pattern, script_url, callbacks);

+ GetDispatcher()->RegisterServiceWorker(

+ provider_id_, pattern, script_url, callbacks);

}

void WebServiceWorkerProviderImpl::unregisterServiceWorker(

const WebURL& pattern,

WebServiceWorkerCallbacks* callbacks) {

- GetDispatcher()->UnregisterServiceWorker(pattern, callbacks);

+ GetDispatcher()->UnregisterServiceWorker(

+ provider_id_, pattern, callbacks);

}

ServiceWorkerDispatcher* WebServiceWorkerProviderImpl::GetDispatcher() {