content/browser/renderer_host/p2p/socket_host_udp.cc - Issue 2253753002: Always use NonBlocking IO for UDP sockets on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_udp.cc

Issue 2253753002: Always use NonBlocking IO for UDP sockets on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/p2p/socket_host_udp.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_udp.cc b/content/browser/renderer_host/p2p/socket_host_udp.cc

index e4e744b7a461da46965ab147d9c7fd90dab47e65..9493a4a119085c12e8a77fe3826718ba30c67b27 100644

--- a/content/browser/renderer_host/p2p/socket_host_udp.cc

+++ b/content/browser/renderer_host/p2p/socket_host_udp.cc

@@ -447,9 +447,6 @@ std::unique_ptr<net::DatagramServerSocket>

P2PSocketHostUdp::DefaultSocketFactory() {

net::UDPServerSocket* socket = new net::UDPServerSocket(

GetContentClient()->browser()->GetNetLog(), net::NetLogSource());

-#if defined(OS_WIN)

- socket->UseNonBlockingIO();

-#endif

return base::WrapUnique(socket);

}

« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host_udp_unittest.cc » ('j') | no next file with comments »