Use testharness.js instead of js-test.js in fast/images.

Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
Committed: https://crrev.com/d33a1f9291e7d9de12795342d8e7ec9bb44ce3d4
Cr-Commit-Position: refs/heads/master@{#412532}

[sivag, 2016-08-17 11:01:09]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
==========

[sivag, 2016-08-17 11:01:09]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com, srirama.m@samsung.com

[sivag, 2016-08-17 11:01:21]

ptal..

[fs, 2016-08-17 11:41:33]

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html
(right):

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html:28: {
Move to previous line.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html:52: 
Drop blank lines

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html (right):

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:1: <script
src="../../resources/testharness.js"></script>
Add doctype.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:9:
assert_equals(false, !gl);
Accessing 'gl' below if it's null will throw and fail the test - hopefully
that's enough? If you want to keep this, then maybe use assert_false instead (or
add one more ! and use assert_true.)

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:19: try {
This shouldn't be needed (uncaught exceptions will fail the test), so this
should be possible to simplify to something like:

gl.bindTexture(...);
gl.texImage2D(...);
assert_equals(gl.getError(), gl.NO_ERROR);

(That would make 'enums' unused too I think.)

[sivag, 2016-08-17 13:31:21]

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html
(right):

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html:28: {
On 2016/08/17 11:41:33, fs wrote:
> Move to previous line.

Done.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/server-side-imagemap.html:52: 
On 2016/08/17 11:41:33, fs wrote:
> Drop blank lines

Done.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html (right):

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:1: <script
src="../../resources/testharness.js"></script>
On 2016/08/17 11:41:33, fs wrote:
> Add doctype.

Done.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:9:
assert_equals(false, !gl);
On 2016/08/17 11:41:33, fs wrote:
> Accessing 'gl' below if it's null will throw and fail the test - hopefully
> that's enough? If you want to keep this, then maybe use assert_false instead
(or
> add one more ! and use assert_true.)

Done.

https://codereview.chromium.org/2253513005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/webgl-teximage2d.html:19: try {
On 2016/08/17 11:41:33, fs wrote:
> This shouldn't be needed (uncaught exceptions will fail the test), so this
> should be possible to simplify to something like:
> 
> gl.bindTexture(...);
> gl.texImage2D(...);
> assert_equals(gl.getError(), gl.NO_ERROR);
> 
> (That would make 'enums' unused too I think.)

Done.

[fs, 2016-08-17 13:37:35]

lgtm

[sivag, 2016-08-17 13:38:19]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2016-08-17 13:38:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:17:47]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
==========

[commit-bot: I haz the power, 2016-08-17 15:17:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 15:19:32]

Description was changed from

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859
==========

to

==========
Use testharness.js instead of js-test.js in fast/images.

This test used testharness.js instead of js-test.js
in server-side-imagemap and webgl-teximage2d.

BUG=637859

Committed: https://crrev.com/d33a1f9291e7d9de12795342d8e7ec9bb44ce3d4
Cr-Commit-Position: refs/heads/master@{#412532}
==========

[commit-bot: I haz the power, 2016-08-17 15:19:33]

Patchset 3 (id:??) landed as
https://crrev.com/d33a1f9291e7d9de12795342d8e7ec9bb44ce3d4
Cr-Commit-Position: refs/heads/master@{#412532}