Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2252523002: [Merge to 2785] Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge to 2785] Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. > Each time I type or delete a character from the omnibox, UpdatePopupApperance is > called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance > was leaking an NSViewController*, as well as all omnibox results. > > BUG=636632 > > Review-Url: https://codereview.chromium.org/2233123003 > Cr-Commit-Position: refs/heads/master@{#411637} > (cherry picked from commit b87e1820a06ac5dd1d9881be5342286fac920e43) Committed: https://chromium.googlesource.com/chromium/src/+/7e53ed2c594fff414ec56f1ae97bfbd297f1d352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -38 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h View 1 chunk +17 lines, -30 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 4 months ago (2016-08-15 22:25:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e53ed2c594fff414ec56f1ae97bfbd297f1d352.

Powered by Google App Engine
This is Rietveld 408576698