Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

Issue 2252523002: [Merge to 2785] Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
index ebad2c899e662e6171cf1f19dcd2a094010690b9..0a9db9ee59fe444f64966cf0fd2825683216d227 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
@@ -12,45 +12,32 @@
class OmniboxPopupViewMac;
-@interface OmniboxPopupCellData : NSObject<NSCopying> {
- @private
- // Left hand side of the separator (e.g. a hyphen).
- NSAttributedString* contents_;
- // Right hand side of the separator (e.g. a hyphen).
- NSAttributedString* description_;
-
- // NOTE: While |prefix_| is used only for postfix suggestions, it still needs
- // to be a member of the class. This allows the |NSAttributedString| instance
- // to stay alive between the call to |drawTitle| and the actual paint event
- // which accesses the |NSAttributedString| instance.
- NSAttributedString* prefix_;
-
- // Common icon that shows next to most rows in the list.
- NSImage* image_;
- // Uncommon icon that only shows on answer rows (e.g. weather).
- NSImage* answerImage_;
-
- // The offset at which the infinite suggestion contents should be displayed.
- CGFloat contentsOffset_;
-
- BOOL isContentsRTL_;
-
- // Is this suggestion an answer or calculator result.
- bool isAnswer_;
-
- AutocompleteMatch::Type matchType_;
-
- int max_lines_;
-}
+@interface OmniboxPopupCellData : NSObject<NSCopying>
+// Left hand side of the separator (e.g. a hyphen).
@property(readonly, retain, nonatomic) NSAttributedString* contents;
+
+// Right hand side of the separator (e.g. a hyphen).
@property(readonly, retain, nonatomic) NSAttributedString* description;
+
+// NOTE: While |prefix_| is used only for postfix suggestions, it still needs
+// to be a member of the class. This allows the |NSAttributedString| instance
+// to stay alive between the call to |drawTitle| and the actual paint event
+// which accesses the |NSAttributedString| instance.
@property(readonly, retain, nonatomic) NSAttributedString* prefix;
+
+// Common icon that shows next to most rows in the list.
@property(readonly, retain, nonatomic) NSImage* image;
@property(retain, nonatomic) NSImage* incognitoImage;
+
+// Uncommon icon that only shows on answer rows (e.g. weather).
@property(readonly, retain, nonatomic) NSImage* answerImage;
+
+// The offset at which the infinite suggestion contents should be displayed.
@property(readonly, nonatomic) CGFloat contentsOffset;
@property(readonly, nonatomic) BOOL isContentsRTL;
+
+// Is this suggestion an answer or calculator result.
@property(readonly, nonatomic) bool isAnswer;
@property(readonly, nonatomic) AutocompleteMatch::Type matchType;
@property(readonly, nonatomic) int max_lines;
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698