Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Issue 2252523002: [Merge to 2785] Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
index 8dbaac18952fe565c0f962e909b38a08e12efb35..f5355de05b418819ac3a571b6389b875292bf56c 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
@@ -115,11 +115,11 @@ void OmniboxPopupViewMac::UpdatePopupAppearance() {
answerImage =
gfx::Image::CreateFrom1xBitmap(model_->answer_bitmap()).CopyNSImage();
}
- [matrix_ setController:[[OmniboxPopupTableController alloc]
+ [matrix_ setController:[[[OmniboxPopupTableController alloc]
initWithMatchResults:result
tableView:matrix_
popupView:*this
- answerImage:answerImage]];
+ answerImage:answerImage] autorelease]];
BOOL is_dark_theme = [matrix_ hasDarkTheme];
[matrix_ setSeparator:[OmniboxPopupCell
createSeparatorStringForDarkTheme:is_dark_theme]];
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698