Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632
Committed: https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43
Cr-Commit-Position: refs/heads/master@{#411637}

[erikchen, 2016-08-10 23:26:08]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-08-10 23:26:19]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2016-08-10 23:26:19]

rsesek: Please review.

[commit-bot: I haz the power, 2016-08-10 23:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-08-11 00:41:30]

Description was changed from

==========
Fix a leak in OmniboxPopupViewMac.

BUG=
==========

to

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=
==========

[erikchen, 2016-08-11 00:41:42]

Description was changed from

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=
==========

to

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=
==========

[erikchen, 2016-08-11 00:56:59]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 00:58:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-08-11 01:02:27]

Description was changed from

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=
==========

to

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632
==========

[commit-bot: I haz the power, 2016-08-11 02:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 02:29:19]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-08-11 15:17:03]

Yikes! I'm wondering if were possible for ASan to have detected this. Do we have
any tests that exercise this code?

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h (right):

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h:18:
base::mac::ObjCPropertyReleaser propertyReleaser_OmniboxPopupCellData_;
While we're modernizing, might as well just push this into the .mm file.

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h (right):

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h:20: : NSObject
<NSTableViewDelegate, NSTableViewDataSource> {
nit: no space between NSObject and <

[erikchen, 2016-08-11 17:45:09]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 17:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-08-11 17:47:52]

The code is not tested by browser_tests. I filed
https://bugs.chromium.org/p/chromium/issues/detail?id=637005

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h (right):

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h:18:
base::mac::ObjCPropertyReleaser propertyReleaser_OmniboxPopupCellData_;
On 2016/08/11 15:17:03, Robert Sesek wrote:
> While we're modernizing, might as well just push this into the .mm file.

Done.

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h (right):

https://codereview.chromium.org/2233123003/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h:20: : NSObject
<NSTableViewDelegate, NSTableViewDataSource> {
On 2016/08/11 15:17:03, Robert Sesek wrote:
> nit: no space between NSObject and <

Done.

[Robert Sesek, 2016-08-11 19:05:35]

LGTM

https://codereview.chromium.org/2233123003/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right):

https://codereview.chromium.org/2233123003/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:400: @private
@private not necessary here, but harmless

[erikchen, 2016-08-11 19:17:12]

https://codereview.chromium.org/2233123003/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right):

https://codereview.chromium.org/2233123003/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:400: @private
On 2016/08/11 19:05:35, Robert Sesek wrote:
> @private not necessary here, but harmless

Done.

[erikchen, 2016-08-11 19:17:19]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-08-11 19:17:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2233123003/#ps120001
(title: "Comments from rsesek.")

[commit-bot: I haz the power, 2016-08-11 19:18:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:39:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-08-12 13:30:09]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-08-12 13:30:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:01:43]

Description was changed from

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632
==========

to

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632
==========

[commit-bot: I haz the power, 2016-08-12 14:03:05]

Description was changed from

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632
==========

to

==========
Fix many memory leaks in chrome/browser/ui/cocoa/omnibox.

Each time I type or delete a character from the omnibox, UpdatePopupApperance is
called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance
was leaking an NSViewController*, as well as all omnibox results.

BUG=636632

Committed: https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43
Cr-Commit-Position: refs/heads/master@{#411637}
==========

[commit-bot: I haz the power, 2016-08-12 14:03:06]

Patchset 7 (id:??) landed as
https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43
Cr-Commit-Position: refs/heads/master@{#411637}