Add crash keys to capture useful data for origin mismatch crashes.

Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org

Committed: https://crrev.com/fbed18057c8891791b821fe387d985a35c933e93
Cr-Commit-Position: refs/heads/master@{#412646}

[nasko, 2016-08-17 19:17:45]

nasko@chromium.org changed reviewers:
+ rsesek@chromium.org

[nasko, 2016-08-17 19:17:45]

Hey Robert,
Can you review this CL for me? It adds a few crash keys to help debugging a hard
to diagnose case.
Thanks in advance!
Nasko

[nasko, 2016-08-17 19:17:53]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:18:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-17 19:28:42]

Description was changed from

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677
==========

to

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
==========

[Robert Sesek, 2016-08-17 19:59:57]

You'll need to add registration entires to chrome/common/crash_keys.cc,
blimp/engine/app/blimp_engine_crash_keys.cc, and
chrome/app/chrome_crash_reporter_client_win.cc

[nasko, 2016-08-17 20:12:45]

On 2016/08/17 19:59:57, Robert Sesek wrote:
> You'll need to add registration entires to chrome/common/crash_keys.cc,
> blimp/engine/app/blimp_engine_crash_keys.cc, and
> chrome/app/chrome_crash_reporter_client_win.cc

Done

[Robert Sesek, 2016-08-17 20:31:50]

lgtm

[nasko, 2016-08-17 20:35:55]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:36:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:46:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nasko, 2016-08-17 20:53:19]

nasko@chromium.org changed reviewers:
+ grt@chromium.org

[nasko, 2016-08-17 20:53:20]

Will TBR grt@chromium.org, since the change is not functional and rsesek@ has
reviewed it.

[nasko, 2016-08-17 20:53:38]

Description was changed from

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
==========

to

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org
==========

[nasko, 2016-08-17 20:53:45]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:54:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:30:15]

Description was changed from

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org
==========

to

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org
==========

[commit-bot: I haz the power, 2016-08-17 21:30:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 21:33:38]

Description was changed from

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org
==========

to

==========
Add crash keys to capture useful data for origin mismatch crashes.

The CHECK in RenderFrameImpl::SendDidCommitProvisionalLoad for mismatch
between origin and URL is still getting hit by users and higher frequency
on Android. This CL adds some of the data I found useful in debugging these
as crash keys, so the values from non-Windows platforms can be reviewed
without needing to process minidumps by hand.

BUG=628677, 630103
TBR=grt@chromium.org

Committed: https://crrev.com/fbed18057c8891791b821fe387d985a35c933e93
Cr-Commit-Position: refs/heads/master@{#412646}
==========

[commit-bot: I haz the power, 2016-08-17 21:33:39]

Patchset 2 (id:??) landed as
https://crrev.com/fbed18057c8891791b821fe387d985a35c933e93
Cr-Commit-Position: refs/heads/master@{#412646}