Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: blimp/engine/app/blimp_engine_crash_keys.cc

Issue 2252153002: Add crash keys to capture useful data for origin mismatch crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_engine_crash_keys.h" 5 #include "blimp/engine/app/blimp_engine_crash_keys.h"
6 6
7 #include "base/debug/crash_logging.h" 7 #include "base/debug/crash_logging.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/crash/core/common/crash_keys.h" 9 #include "components/crash/core/common/crash_keys.h"
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 { "initrf_parent_proxy_exists", crash_keys::kSmallSize }, 63 { "initrf_parent_proxy_exists", crash_keys::kSmallSize },
64 { "initrf_render_view_is_live", crash_keys::kSmallSize }, 64 { "initrf_render_view_is_live", crash_keys::kSmallSize },
65 { "initrf_parent_is_in_same_site_instance", crash_keys::kSmallSize}, 65 { "initrf_parent_is_in_same_site_instance", crash_keys::kSmallSize},
66 { "initrf_parent_process_is_live", crash_keys::kSmallSize}, 66 { "initrf_parent_process_is_live", crash_keys::kSmallSize},
67 { "initrf_root_is_in_same_site_instance", crash_keys::kSmallSize}, 67 { "initrf_root_is_in_same_site_instance", crash_keys::kSmallSize},
68 { "initrf_root_is_in_same_site_instance_as_parent", 68 { "initrf_root_is_in_same_site_instance_as_parent",
69 crash_keys::kSmallSize}, 69 crash_keys::kSmallSize},
70 { "initrf_root_process_is_live", crash_keys::kSmallSize}, 70 { "initrf_root_process_is_live", crash_keys::kSmallSize},
71 { "initrf_root_proxy_is_live", crash_keys::kSmallSize}, 71 { "initrf_root_proxy_is_live", crash_keys::kSmallSize},
72 72
73 // Temporary for https://crbug.com/630103.
74 { "origin_mismatch_url", crash_keys::kLargeSize },
75 { "origin_mismatch_origin", crash_keys::kMediumSize },
76 { "origin_mismatch_transition", crash_keys::kSmallSize },
77 { "origin_mismatch_redirects", crash_keys::kSmallSize },
78 { "origin_mismatch_same_page", crash_keys::kSmallSize },
79
73 // Temporary for https://crbug.com/612711. 80 // Temporary for https://crbug.com/612711.
74 { "aci_wrong_sp_extension_id", crash_keys::kSmallSize }, 81 { "aci_wrong_sp_extension_id", crash_keys::kSmallSize },
75 82
76 // Temporary for https://crbug.com/616149. 83 // Temporary for https://crbug.com/616149.
77 { "existing_extension_pref_value_type", crash_keys::kSmallSize }, 84 { "existing_extension_pref_value_type", crash_keys::kSmallSize },
78 85
79 // Temporary for https://crbug.com/630495. 86 // Temporary for https://crbug.com/630495.
80 { "swdh_register_cannot_host_url", crash_keys::kLargeSize }, 87 { "swdh_register_cannot_host_url", crash_keys::kLargeSize },
81 { "swdh_register_cannot_scope_url", crash_keys::kLargeSize }, 88 { "swdh_register_cannot_scope_url", crash_keys::kLargeSize },
82 { "swdh_register_cannot_script_url", crash_keys::kLargeSize }, 89 { "swdh_register_cannot_script_url", crash_keys::kLargeSize },
83 90
84 // Temporary for https://crbug.com/619294. 91 // Temporary for https://crbug.com/619294.
85 { "swdh_unregister_cannot_host_url", crash_keys::kLargeSize }, 92 { "swdh_unregister_cannot_host_url", crash_keys::kLargeSize },
86 { "swdh_unregister_cannot_scope_url", crash_keys::kLargeSize }, 93 { "swdh_unregister_cannot_scope_url", crash_keys::kLargeSize },
87 94
88 // Temporary for https://crbug.com/630496. 95 // Temporary for https://crbug.com/630496.
89 { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize }, 96 { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize },
90 { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, 97 { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize },
91 }; 98 };
92 99
93 return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys), 100 return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys),
94 crash_keys::kChunkMaxLength); 101 crash_keys::kChunkMaxLength);
95 } 102 }
96 103
97 } // namespace engine 104 } // namespace engine
98 } // namespace blimp 105 } // namespace blimp
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698