Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 2252153002: Add crash keys to capture useful data for origin mismatch crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 // Temporary for https://crbug.com/591478. 186 // Temporary for https://crbug.com/591478.
187 { "initrf_parent_proxy_exists", kSmallSize }, 187 { "initrf_parent_proxy_exists", kSmallSize },
188 { "initrf_render_view_is_live", kSmallSize }, 188 { "initrf_render_view_is_live", kSmallSize },
189 { "initrf_parent_is_in_same_site_instance", kSmallSize}, 189 { "initrf_parent_is_in_same_site_instance", kSmallSize},
190 { "initrf_parent_process_is_live", kSmallSize}, 190 { "initrf_parent_process_is_live", kSmallSize},
191 { "initrf_root_is_in_same_site_instance", kSmallSize}, 191 { "initrf_root_is_in_same_site_instance", kSmallSize},
192 { "initrf_root_is_in_same_site_instance_as_parent", kSmallSize}, 192 { "initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
193 { "initrf_root_process_is_live", kSmallSize}, 193 { "initrf_root_process_is_live", kSmallSize},
194 { "initrf_root_proxy_is_live", kSmallSize}, 194 { "initrf_root_proxy_is_live", kSmallSize},
195 195
196 // Temporary for https://crbug.com/630103.
197 { "origin_mismatch_url", crash_keys::kLargeSize },
198 { "origin_mismatch_origin", crash_keys::kMediumSize },
199 { "origin_mismatch_transition", crash_keys::kSmallSize },
200 { "origin_mismatch_redirects", crash_keys::kSmallSize },
201 { "origin_mismatch_same_page", crash_keys::kSmallSize },
202
196 // Temporary for https://crbug.com/612711. 203 // Temporary for https://crbug.com/612711.
197 { "aci_wrong_sp_extension_id", kSmallSize }, 204 { "aci_wrong_sp_extension_id", kSmallSize },
198 205
199 // Temporary for https://crbug.com/616149. 206 // Temporary for https://crbug.com/616149.
200 { "existing_extension_pref_value_type", crash_keys::kSmallSize }, 207 { "existing_extension_pref_value_type", crash_keys::kSmallSize },
201 208
202 // Temporary for https://crbug.com/630495. 209 // Temporary for https://crbug.com/630495.
203 { "swdh_register_cannot_host_url", crash_keys::kLargeSize }, 210 { "swdh_register_cannot_host_url", crash_keys::kLargeSize },
204 { "swdh_register_cannot_scope_url", crash_keys::kLargeSize }, 211 { "swdh_register_cannot_scope_url", crash_keys::kLargeSize },
205 { "swdh_register_cannot_script_url", crash_keys::kLargeSize }, 212 { "swdh_register_cannot_script_url", crash_keys::kLargeSize },
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 } 355 }
349 356
350 ScopedPrinterInfo::~ScopedPrinterInfo() { 357 ScopedPrinterInfo::~ScopedPrinterInfo() {
351 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 358 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
352 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 359 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
353 base::debug::ClearCrashKey(key); 360 base::debug::ClearCrashKey(key);
354 } 361 }
355 } 362 }
356 363
357 } // namespace crash_keys 364 } // namespace crash_keys
OLDNEW
« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698