Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2252153002: Add crash keys to capture useful data for origin mismatch crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Register crash keys. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 // Temporary for https://crbug.com/591478. 131 // Temporary for https://crbug.com/591478.
132 {"initrf_parent_proxy_exists", kSmallSize}, 132 {"initrf_parent_proxy_exists", kSmallSize},
133 {"initrf_render_view_is_live", kSmallSize}, 133 {"initrf_render_view_is_live", kSmallSize},
134 {"initrf_parent_is_in_same_site_instance", kSmallSize}, 134 {"initrf_parent_is_in_same_site_instance", kSmallSize},
135 {"initrf_parent_process_is_live", kSmallSize}, 135 {"initrf_parent_process_is_live", kSmallSize},
136 {"initrf_root_is_in_same_site_instance", kSmallSize}, 136 {"initrf_root_is_in_same_site_instance", kSmallSize},
137 {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize}, 137 {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
138 {"initrf_root_process_is_live", kSmallSize}, 138 {"initrf_root_process_is_live", kSmallSize},
139 {"initrf_root_proxy_is_live", kSmallSize}, 139 {"initrf_root_proxy_is_live", kSmallSize},
140 140
141 // Temporary for https://crbug.com/630103.
142 { "origin_mismatch_url", crash_keys::kLargeSize },
143 { "origin_mismatch_origin", crash_keys::kMediumSize },
144 { "origin_mismatch_transition", crash_keys::kSmallSize },
145 { "origin_mismatch_redirects", crash_keys::kSmallSize },
146 { "origin_mismatch_same_page", crash_keys::kSmallSize },
147
141 // Temporary for https://crbug.com/612711. 148 // Temporary for https://crbug.com/612711.
142 {"aci_wrong_sp_extension_id", kSmallSize}, 149 {"aci_wrong_sp_extension_id", kSmallSize},
143 150
144 // Temporary for http://crbug.com/621730 151 // Temporary for http://crbug.com/621730
145 {"postmessage_src_origin", kMediumSize}, 152 {"postmessage_src_origin", kMediumSize},
146 {"postmessage_dst_origin", kMediumSize}, 153 {"postmessage_dst_origin", kMediumSize},
147 {"postmessage_dst_url", kLargeSize}, 154 {"postmessage_dst_url", kLargeSize},
148 {"postmessage_script_info", kLargeSize}, 155 {"postmessage_script_info", kLargeSize},
149 156
150 // Temporary for https://crbug.com/616149. 157 // Temporary for https://crbug.com/616149.
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 bool ChromeCrashReporterClient::GetCollectStatsConsent() { 362 bool ChromeCrashReporterClient::GetCollectStatsConsent() {
356 return install_static::GetCollectStatsConsent(); 363 return install_static::GetCollectStatsConsent();
357 } 364 }
358 365
359 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 366 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
360 const std::string& process_type) { 367 const std::string& process_type) {
361 return process_type == install_static::kRendererProcess || 368 return process_type == install_static::kRendererProcess ||
362 process_type == install_static::kPpapiPluginProcess || 369 process_type == install_static::kPpapiPluginProcess ||
363 process_type == install_static::kGpuProcess; 370 process_type == install_static::kGpuProcess;
364 } 371 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698