Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2252123002: [Remoting Android] Remove Cardboard Code (Closed)

Created:
4 years, 4 months ago by Yuwei
Modified:
4 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Remove Cardboard Code The cardboard code has long been abandoned but it is still being compiled and has dependencies on multiple active components, which gives us burden to maintain the obsolete code. The old cardboard SDK is also being deprecated so we have no choice other than removing these code. This CL removes the cardboard feature and the cardboard code. BUG=638655 Committed: https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788 Cr-Commit-Position: refs/heads/master@{#412683}

Patch Set 1 #

Patch Set 2 : Reviewer's Feedback - Removed unused const and strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2148 lines) Patch
M remoting/android/BUILD.gn View 2 chunks +0 lines, -20 lines 0 comments Download
M remoting/android/client_java_tmpl.gni View 2 chunks +0 lines, -11 lines 0 comments Download
M remoting/android/java/AndroidManifest.xml.jinja2 View 3 chunks +0 lines, -18 lines 0 comments Download
D remoting/android/java/res/layout/cardboard_desktop.xml View 1 chunk +0 lines, -13 lines 0 comments Download
M remoting/android/java/res/menu/desktop_actionbar.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 1 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 10 chunks +2 lines, -77 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/CardboardRenderer.java View 1 chunk +0 lines, -437 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/CardboardUtil.java View 1 chunk +0 lines, -56 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/Cursor.java View 1 chunk +0 lines, -248 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/Desktop.java View 1 chunk +0 lines, -250 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/DesktopActivity.java View 1 chunk +0 lines, -207 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/MenuBar.java View 1 chunk +0 lines, -107 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/MenuItem.java View 1 chunk +0 lines, -181 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/Photosphere.java View 1 chunk +0 lines, -313 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/ShaderHelper.java View 1 chunk +0 lines, -104 lines 0 comments Download
D remoting/android/java/src/org/chromium/chromoting/cardboard/TextureHelper.java View 1 chunk +0 lines, -85 lines 0 comments Download
M remoting/android/remoting_apk_tmpl.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/remoting_options.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Yuwei
ptal. Thanks!
4 years, 4 months ago (2016-08-17 18:28:40 UTC) #4
Lambros
+bajones FYI lgtm There is also a constant in Chromoting.java, and some strings in remoting/resources/remoting_strings.grd
4 years, 4 months ago (2016-08-17 21:48:09 UTC) #8
bajones
Thanks for this! Sounds like great functionality, I'd love to see it come back some ...
4 years, 4 months ago (2016-08-17 21:50:58 UTC) #9
Yuwei
On 2016/08/17 21:48:09, Lambros wrote: > +bajones FYI > > lgtm > > There is ...
4 years, 4 months ago (2016-08-17 22:07:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252123002/20001
4 years, 4 months ago (2016-08-17 22:08:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 23:10:48 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:19:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17aba88a72da5ac6a92e8d6b162f5ea7fdbfd788
Cr-Commit-Position: refs/heads/master@{#412683}

Powered by Google App Engine
This is Rietveld 408576698