Use MD-ash's auto hide behavior for arc++ windows.

Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Committed: https://crrev.com/41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef
Cr-Original-Commit-Position: refs/heads/master@{#412309}
Cr-Commit-Position: refs/heads/master@{#412352}

[oshima, 2016-08-15 17:10:35]

Description was changed from

==========
Add AUTO_HIDE_INVISIBLE mode for arc++.

This is add MD like auto hide for arc++ windows. I'll remove this once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

to

==========
Add AUTO_HIDE_INVISIBLE mode for arc++.

This add a runtime flag to enable MD-ash's auto hide behavior for arc++ windows.
I'll remove this mode once MD ash is launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

[oshima, 2016-08-15 17:10:35]

oshima@chromium.org changed reviewers:
+ tdanderson@chromium.org

[oshima, 2016-08-15 17:16:24]

Description was changed from

==========
Add AUTO_HIDE_INVISIBLE mode for arc++.

This add a runtime flag to enable MD-ash's auto hide behavior for arc++ windows.
I'll remove this mode once MD ash is launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

[oshima, 2016-08-15 17:16:53]

oshima@chromium.org changed reviewers:
+ reveman@chromium.org

[oshima, 2016-08-15 17:16:54]

reveman@ -> components/exo
tdanderson@ -> the rest

[reveman, 2016-08-15 17:28:01]

components/exo lgtm

https://codereview.chromium.org/2248773002/diff/1/ash/wm/immersive_fullscreen...
File ash/wm/immersive_fullscreen_controller.cc (right):

https://codereview.chromium.org/2248773002/diff/1/ash/wm/immersive_fullscreen...
ash/wm/immersive_fullscreen_controller.cc:272: LOG(ERROR) << "SetEnabled:" <<
enabled;
debug code?

https://codereview.chromium.org/2248773002/diff/1/ash/wm/immersive_fullscreen...
ash/wm/immersive_fullscreen_controller.cc:276: //
window_state->_shelf_when_fullscreen(!enabled);
debug code?

https://codereview.chromium.org/2248773002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2248773002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:56: // TODO(oshima): Use SHELF_AUTOHIDE_VISIBLE
for SYSTEM_UI_VISIBLE case.
nit: SHELF_AUTO_HIDE_VISIBLE

[oshima, 2016-08-15 17:34:34]

https://codereview.chromium.org/2248773002/diff/1/ash/wm/immersive_fullscreen...
File ash/wm/immersive_fullscreen_controller.cc (right):

https://codereview.chromium.org/2248773002/diff/1/ash/wm/immersive_fullscreen...
ash/wm/immersive_fullscreen_controller.cc:272: LOG(ERROR) << "SetEnabled:" <<
enabled;
On 2016/08/15 17:28:01, reveman wrote:
> debug code?

Uploading new CL was stuck in the comment input :(. Uploaded new patch.

https://codereview.chromium.org/2248773002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2248773002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:56: // TODO(oshima): Use SHELF_AUTOHIDE_VISIBLE
for SYSTEM_UI_VISIBLE case.
On 2016/08/15 17:28:01, reveman wrote:
> nit: SHELF_AUTO_HIDE_VISIBLE

I removed it because new MD auto hide does not have visible autohide.

[tdanderson, 2016-08-15 19:51:38]

LGTM

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
File ash/common/wm/window_state.h (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
ash/common/wm/window_state.h:204: SHELF_AUTO_HIDE_INVISIBLE,
Can you include a brief comment to explain that SHELF_AUTO_HIDE_INVISIBLE is
being used for a temporary workaround (so nobody else comes along and starts
using it without a good reason)?

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
ash/common/wm/window_state.h:209: return shelf_mode_in_fullscreen_;  //
hide_shelf_when_fullscreen_;
Comment left over from debugging?

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:277: break;
Is it possible to simplify as follows or do you need to leave as-is for things
to work?

case wm::WindowState::SHELF_AUTO_HIDE_INVISIBLE:
  invisible_auto_hide_shelf_ = true;
case wm::WindowState::SHELF_AUTO_HIDE_VISIBLE:
  // A hack to...
  ...
  break;

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:12: #include
"ash/common/shelf/shelf_constants.h"
Do you need this include here?

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:576: // Switcvh from invisible to
visible autodhide.
nit: 'Switch', "autohide'

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager_unittest.cc:585: // Switcvh from invisible to
visible autodhide.
nit: 'Switch'

[oshima, 2016-08-15 20:01:50]

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
File ash/common/wm/window_state.h (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
ash/common/wm/window_state.h:204: SHELF_AUTO_HIDE_INVISIBLE,
On 2016/08/15 19:51:37, tdanderson wrote:
> Can you include a brief comment to explain that SHELF_AUTO_HIDE_INVISIBLE is
> being used for a temporary workaround (so nobody else comes along and starts
> using it without a good reason)?

I ipdated the enum comment because this enum will be removed.

https://codereview.chromium.org/2248773002/diff/20001/ash/common/wm/window_st...
ash/common/wm/window_state.h:209: return shelf_mode_in_fullscreen_;  //
hide_shelf_when_fullscreen_;
On 2016/08/15 19:51:37, tdanderson wrote:
> Comment left over from debugging?

Done.

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:277: break;
On 2016/08/15 19:51:37, tdanderson wrote:
> Is it possible to simplify as follows or do you need to leave as-is for things
> to work?
> 
> case wm::WindowState::SHELF_AUTO_HIDE_INVISIBLE:
>   invisible_auto_hide_shelf_ = true;
> case wm::WindowState::SHELF_AUTO_HIDE_VISIBLE:
>   // A hack to...
>   ...
>   break;

Done.

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2248773002/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:12: #include
"ash/common/shelf/shelf_constants.h"
On 2016/08/15 19:51:37, tdanderson wrote:
> Do you need this include here?

Done.

[oshima, 2016-08-15 20:05:38]

oshima@chromium.org changed reviewers:
+ sky@chromium.org

[oshima, 2016-08-15 20:05:39]

sky@ -> owners review for following directories

chrome/browser/ui
chrome/browser/notifications

[sky, 2016-08-15 22:11:13]

LGTM

[oshima, 2016-08-15 23:39:47]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-08-15 23:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2248773002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-08-15 23:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 00:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 00:07:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-08-16 01:01:32]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-08-16 01:01:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2248773002/#ps60001
(title: "update browser test to match new api")

[commit-bot: I haz the power, 2016-08-16 01:02:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-08-16 01:10:07]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2016-08-16 01:13:17]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 01:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 01:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 01:45:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-08-16 14:18:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 14:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:00:47]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-16 15:56:02]

terry, can you take an another look at shelf_layout_manager?

looks like it expects that exactly same state change from auto-hide to auto-hide
should not update the state.

[tdanderson, 2016-08-16 19:27:21]

Patch set 6 LGTM

[oshima, 2016-08-16 19:44:01]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-08-16 19:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2248773002/#ps100001
(title: "fix test")

[commit-bot: I haz the power, 2016-08-16 19:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 19:49:02]

Description was changed from

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

[commit-bot: I haz the power, 2016-08-16 19:49:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-16 19:51:10]

Description was changed from

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

[commit-bot: I haz the power, 2016-08-16 19:51:11]

Patchset 6 (id:??) landed as
https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}

[Avi (use Gerrit), 2016-08-16 20:14:05]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2248913005/ by avi@chromium.org.

The reason for reverting is: Breaks every Linux ChromiumOS bot:

FAILED: obj/components/exo/exo/shell_surface.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/components/exo/exo/shell_surface.o.d -DV8_DEPRECATION_WARNINGS
-DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1
-DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
-DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD
-DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=277962-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL
-DTOOLKIT_VIEWS=1 -DSK_IGNORE_DW_GRAY_FIX
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DENABLE_IPC_FUZZER
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT=
-DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/khronos -I../../gpu
-Igen/ash/common/strings -Igen/ash/resources -I../../skia/config
-I../../skia/ext -I../../third_party/skia/include/c
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
-I../../third_party/icu/source/common -I../../third_party/icu/source/i18n
-I../../third_party/mesa/src/include -Igen -Igen/ui/views/resources
-fno-strict-aliasing -funwind-tables -fPIC -pipe
-B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fdebug-prefix-map=/mnt/data/b/c/b/linux_chromium_gn_chromeos/src=. -pthread
-m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-deprecated-register -Wno-unneeded-internal-declaration
-Wno-inconsistent-missing-override -Wno-shift-negative-value
-Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident
-fdata-sections -ffunction-sections -g0 -fvisibility=hidden -Xclang -load
-Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
-plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
-plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene
-Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
-std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c
../../components/exo/shell_surface.cc -o obj/components/exo/exo/shell_surface.o
../../components/exo/shell_surface.cc:57:8: error: no member named 'Shell' in
namespace 'ash'
  ash::Shell::GetInstance()->UpdateShelfVisibility();
  ~~~~~^
1 error generated.
.

[oshima, 2016-08-16 20:57:55]

On 2016/08/16 20:14:05, Avi wrote:
> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/2248913005/ by mailto:avi@chromium.org.
> 
> The reason for reverting is: Breaks every Linux ChromiumOS bot:
> 
> FAILED: obj/components/exo/exo/shell_surface.o 
> /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
> -MMD -MF obj/components/exo/exo/shell_surface.o.d -DV8_DEPRECATION_WARNINGS
> -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
> -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV
> -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1
> -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1
> -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
> -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
> -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
> -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING
> -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD
> -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
> -DCR_CLANG_REVISION=277962-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL
> -DTOOLKIT_VIEWS=1 -DSK_IGNORE_DW_GRAY_FIX
> -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1
-DENABLE_IPC_FUZZER
> -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT=
> -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
> -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/khronos
-I../../gpu
> -Igen/ash/common/strings -Igen/ash/resources -I../../skia/config
> -I../../skia/ext -I../../third_party/skia/include/c
> -I../../third_party/skia/include/config -I../../third_party/skia/include/core
> -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images
> -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
> -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
> -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
> -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu
> -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n
> -I../../third_party/mesa/src/include -Igen -Igen/ui/views/resources
> -fno-strict-aliasing -funwind-tables -fPIC -pipe
> -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
> -fdebug-prefix-map=/mnt/data/b/c/b/linux_chromium_gn_chromeos/src=. -pthread
> -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers
> -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
> -Wno-deprecated-register -Wno-unneeded-internal-declaration
> -Wno-inconsistent-missing-override -Wno-shift-negative-value
> -Wno-undefined-var-template -Wno-nonportable-include-path -O2 -fno-ident
> -fdata-sections -ffunction-sections -g0 -fvisibility=hidden -Xclang -load
> -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
> -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -Xclang
> -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene
> -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
> -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c
> ../../components/exo/shell_surface.cc -o
obj/components/exo/exo/shell_surface.o
> ../../components/exo/shell_surface.cc:57:8: error: no member named 'Shell' in
> namespace 'ash'
>   ash::Shell::GetInstance()->UpdateShelfVisibility();
>   ~~~~~^
> 1 error generated.
> .

Thanks for reverting. Looks like it had conflict with 
https://codereview.chromium.org/2242283002

[oshima, 2016-08-16 21:08:09]

Description was changed from

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

[oshima, 2016-08-16 21:08:57]

peng, I'm adding ash/shell.h back for this CL because this needs to be merged to
53. I'll move it to WmHelper in a separate CL.

[oshima, 2016-08-16 21:09:13]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 21:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 21:46:32]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-16 22:02:41]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-08-16 22:02:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, reveman@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2248773002/#ps120001
(title: "Add ash/shell.h bac to merge to m53")

[commit-bot: I haz the power, 2016-08-16 22:03:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:09:28]

Description was changed from

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

[commit-bot: I haz the power, 2016-08-16 22:09:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-16 22:11:34]

Description was changed from

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Cr-Commit-Position: refs/heads/master@{#412309}
==========

to

==========
Use MD-ash's auto hide behavior for arc++ windows.

This add a runtime flag to enable MD-ash's auto hide behavior , which makes the
shelf invisible, for arc++ windows. I'll remove this mode once MD ash is
launched.

BUG=634566
TEST=covered by unit test. Manually tested on minnie.

Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700
Committed: https://crrev.com/41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef
Cr-Original-Commit-Position: refs/heads/master@{#412309}
Cr-Commit-Position: refs/heads/master@{#412352}
==========

[commit-bot: I haz the power, 2016-08-16 22:11:35]

Patchset 7 (id:??) landed as
https://crrev.com/41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef
Cr-Commit-Position: refs/heads/master@{#412352}