chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc - Issue 2248773002: Use MD-ash's auto hide behavior for arc++ windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc

Issue 2248773002: Use MD-ash's auto hide behavior for arc++ windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ash/shell.h bac to merge to m53 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc

diff --git a/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc b/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc

index 453939f4fbc82e6fffc1f8ddd79928063981f8bf..a0d766a722b722b65d322cc7d55f761953ec514e 100644

--- a/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc

+++ b/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc

@@ -203,7 +203,8 @@ IN_PROC_BROWSER_TEST_F(ScreenLockerTest, TestFullscreenExit) {

->ToggleBrowserFullscreenMode();

waiter.Wait(false /* not locked */, true /* full screen */);

EXPECT_TRUE(browser_window->IsFullscreen());

- EXPECT_FALSE(window_state->hide_shelf_when_fullscreen());

+ EXPECT_NE(ash::wm::WindowState::SHELF_HIDDEN,

+ window_state->shelf_mode_in_fullscreen());

EXPECT_FALSE(tester->IsLocked());

}

{

@@ -212,7 +213,8 @@ IN_PROC_BROWSER_TEST_F(ScreenLockerTest, TestFullscreenExit) {

tester->EmulateWindowManagerReady();

waiter.Wait(true /* locked */, true /* full screen */);

EXPECT_TRUE(browser_window->IsFullscreen());

- EXPECT_FALSE(window_state->hide_shelf_when_fullscreen());

+ EXPECT_NE(ash::wm::WindowState::SHELF_HIDDEN,

+ window_state->shelf_mode_in_fullscreen());

EXPECT_TRUE(tester->IsLocked());

}

UserContext user_context(login::StubAccountId());

@@ -244,7 +246,8 @@ IN_PROC_BROWSER_TEST_F(ScreenLockerTest, TestFullscreenExit) {

->EnterFullscreenModeForTab(web_contents, GURL());

waiter.Wait(false /* not locked */, true /* fullscreen */);

EXPECT_TRUE(browser_window->IsFullscreen());

- EXPECT_TRUE(window_state->hide_shelf_when_fullscreen());

+ EXPECT_EQ(ash::wm::WindowState::SHELF_HIDDEN,

+ window_state->shelf_mode_in_fullscreen());

EXPECT_FALSE(tester->IsLocked());

}

{