Add an adapter layer (WMHelper) between exo and ash.

Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
Committed: https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856
Cr-Commit-Position: refs/heads/master@{#412250}

[Peng, 2016-08-15 20:48:50]

Description was changed from

==========
Add an adapter layer (WMHelper) between exo and ash.

BUG=637914
==========

to

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolated
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

[Peng, 2016-08-15 21:03:39]

Description was changed from

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolated
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

to

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

[Peng, 2016-08-15 21:04:16]

penghuang@chromium.org changed reviewers:
+ reveman@chromium.org

[Peng, 2016-08-15 21:04:16]

Hi David, Could you please take a look this CL? Thanks.

[reveman, 2016-08-16 13:14:15]

lgtm with nits

what's the plan for the unit tests? should they use this wrapper too?

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helper.h
File components/exo/wm_helper.h (right):

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:110: // aura::client::ActivationChangeObserver
overrides:
nit: "// Overridden from aura::client::ActivationChangeObserver:" to be
consistent with the rest of the exo/ code

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:116: // aura::client::FocusChangeObserver overrides:
nit: // Overridden from..

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:120: // aura::client::CursorClientObserver overrides:
nit: // Overridden from..

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:124: // ash::ShellObserver overrides:
nit: // Overridden from..

[Peng, 2016-08-16 14:01:29]

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helper.h
File components/exo/wm_helper.h (right):

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:110: // aura::client::ActivationChangeObserver
overrides:
On 2016/08/16 13:14:14, reveman wrote:
> nit: "// Overridden from aura::client::ActivationChangeObserver:" to be
> consistent with the rest of the exo/ code

Done.

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:116: // aura::client::FocusChangeObserver overrides:
On 2016/08/16 13:14:14, reveman wrote:
> nit: // Overridden from.. 

Done.

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:120: // aura::client::CursorClientObserver overrides:
On 2016/08/16 13:14:14, reveman wrote:
> nit: // Overridden from..

Done.

https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
components/exo/wm_helper.h:124: // ash::ShellObserver overrides:
On 2016/08/16 13:14:14, reveman wrote:
> nit: // Overridden from..

Done.

[Peng, 2016-08-16 14:03:16]

On 2016/08/16 13:14:15, reveman wrote:
> lgtm with nits

It is better to use the WMHelper in unittests. I changed the DEPS to only use
the ash in wm_helper.* and *_unittest.cc, and also added a TODO for me.

> 
> what's the plan for the unit tests? should they use this wrapper too?
> 
>
https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helper.h
> File components/exo/wm_helper.h (right):
> 
>
https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
> components/exo/wm_helper.h:110: // aura::client::ActivationChangeObserver
> overrides:
> nit: "// Overridden from aura::client::ActivationChangeObserver:" to be
> consistent with the rest of the exo/ code
> 
>
https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
> components/exo/wm_helper.h:116: // aura::client::FocusChangeObserver
overrides:
> nit: // Overridden from..
> 
>
https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
> components/exo/wm_helper.h:120: // aura::client::CursorClientObserver
overrides:
> nit: // Overridden from..
> 
>
https://codereview.chromium.org/2242283002/diff/40001/components/exo/wm_helpe...
> components/exo/wm_helper.h:124: // ash::ShellObserver overrides:
> nit: // Overridden from..

[Peng, 2016-08-16 14:03:29]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-08-16 14:03:30]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2242283002/#ps60001
(title: "Update")

[commit-bot: I haz the power, 2016-08-16 14:03:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 14:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 14:09:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peng, 2016-08-16 14:12:06]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2016-08-16 14:12:06]

+ @sky for //components/exo/DEPS

Hi Scott, PTAL. Thanks.

[Peng, 2016-08-16 14:44:29]

On 2016/08/16 14:12:06, Peng wrote:
> + @sky for //components/exo/DEPS
> 
> Hi Scott, PTAL. Thanks.

Scott, Just found out I shouldn't modify the DEPS, because many files are still
using ash for other reasons. Remove all changes in DEPS.

[Peng, 2016-08-16 14:44:35]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-08-16 14:44:35]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2242283002/#ps80001
(title: "Fix build errors.")

[commit-bot: I haz the power, 2016-08-16 14:44:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:40:22]

Description was changed from

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

to

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

[commit-bot: I haz the power, 2016-08-16 15:40:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-16 15:42:09]

Description was changed from

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914
==========

to

==========
Add an adapter layer (WMHelper) between exo and ash.

WMHelper is for accessing WM related features. It isolates
exo from underneath WM. In future, we will port exo onto
mus+ash, and the ash::Shell is not available, so we need
this adapter layer for running exo on both mus+ash and
non-mus+ash environments.

BUG=637914

Committed: https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856
Cr-Commit-Position: refs/heads/master@{#412250}
==========

[commit-bot: I haz the power, 2016-08-16 15:42:10]

Patchset 5 (id:??) landed as
https://crrev.com/76977a523349abd17da5e57f6935ed73e9d35856
Cr-Commit-Position: refs/heads/master@{#412250}