Remove default textures in (!bind_generates_resource) context groups.

Remove default textures in (!bind_generates_resource) context groups.

Previously texture ids for default textures in Renderer
compositor and Browser compositor contexts are different,
so during a context switch we'd be restoring default
textures for all units which can be slow.

This change makes all default textures 'null' for context groups
with bind_generates_resource == false.

Since Renderer and Browser compositors will both have 'null' default
textures, state switching will be avoided.

BUG=333063, 353822
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262288

[vmiura, 2014-04-03 23:12:28]

PTAL.

[Ken Russell (switch to Gerrit), 2014-04-04 01:09:40]

Sorry, I'm completely swamped and won't be able to review this. I fully trust
sievers@ and piman@'s reviews.

[piman, 2014-04-04 02:50:28]

Mostly nits.

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group.cc:183:
texture_manager_->set_use_default_textures(bind_generates_resource_);
Could we pass this to the constructor? It's not like it's something we can
change dynamically.

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group_unittest.cc:52: bool
bind_generates_resource_;
is anything setting this to a non-default value?

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/t...
File gpu/command_buffer/service/texture_manager_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/t...
gpu/command_buffer/service/texture_manager_unittest.cc:91: bool
use_default_textures_;
Same here, is there anything that sets this?

[vmiura, 2014-04-04 18:32:56]

PTAL

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group.cc:183:
texture_manager_->set_use_default_textures(bind_generates_resource_);
On 2014/04/04 02:50:28, piman wrote:
> Could we pass this to the constructor? It's not like it's something we can
> change dynamically.

There are many tests that construct this, so originally I thought we should
default it to 'false' and set as needed.  But I changed it.

Done.

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group_unittest.cc:52: bool
bind_generates_resource_;
On 2014/04/04 02:50:28, piman wrote:
> is anything setting this to a non-default value?

Changed to kUseDefaultTextures.

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/t...
File gpu/command_buffer/service/texture_manager_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/t...
gpu/command_buffer/service/texture_manager_unittest.cc:91: bool
use_default_textures_;
On 2014/04/04 02:50:28, piman wrote:
> Same here, is there anything that sets this?

Changed to kUseDefaultTextures.

[piman, 2014-04-04 22:47:44]

lgtm

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group_unittest.cc:52: bool
bind_generates_resource_;
On 2014/04/04 18:32:57, vmiura wrote:
> On 2014/04/04 02:50:28, piman wrote:
> > is anything setting this to a non-default value?
> 
> Changed to kUseDefaultTextures.

I think you missed this file.

[vmiura, 2014-04-05 01:54:29]

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
File gpu/command_buffer/service/context_group_unittest.cc (right):

https://codereview.chromium.org/224763002/diff/1/gpu/command_buffer/service/c...
gpu/command_buffer/service/context_group_unittest.cc:52: bool
bind_generates_resource_;
On 2014/04/04 22:47:44, piman wrote:
> On 2014/04/04 18:32:57, vmiura wrote:
> > On 2014/04/04 02:50:28, piman wrote:
> > > is anything setting this to a non-default value?
> > 
> > Changed to kUseDefaultTextures.
> 
> I think you missed this file.

Done.  Changed to kBindGeneratesResource.

[piman, 2014-04-05 05:16:59]

lgtm3

[vmiura, 2014-04-07 17:26:01]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-04-07 17:26:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmiura@chromium.org/224763002/40001

[commit-bot: I haz the power, 2014-04-07 23:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 23:28:28]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[vmiura, 2014-04-07 23:43:34]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-04-07 23:43:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmiura@chromium.org/224763002/40001

[commit-bot: I haz the power, 2014-04-08 03:52:00]

Change committed as 262288