Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: gpu/command_buffer/service/context_group_unittest.cc

Issue 224763002: Remove default textures in (!bind_generates_resource) context groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/context_group.h" 5 #include "gpu/command_buffer/service/context_group.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "gpu/command_buffer/service/gles2_cmd_decoder_mock.h" 8 #include "gpu/command_buffer/service/gles2_cmd_decoder_mock.h"
9 #include "gpu/command_buffer/service/test_helper.h" 9 #include "gpu/command_buffer/service/test_helper.h"
10 #include "gpu/command_buffer/service/texture_manager.h" 10 #include "gpu/command_buffer/service/texture_manager.h"
(...skipping 12 matching lines...) Expand all
23 using ::testing::SetArrayArgument; 23 using ::testing::SetArrayArgument;
24 using ::testing::SetArgumentPointee; 24 using ::testing::SetArgumentPointee;
25 using ::testing::StrEq; 25 using ::testing::StrEq;
26 using ::testing::StrictMock; 26 using ::testing::StrictMock;
27 27
28 namespace gpu { 28 namespace gpu {
29 namespace gles2 { 29 namespace gles2 {
30 30
31 class ContextGroupTest : public testing::Test { 31 class ContextGroupTest : public testing::Test {
32 public: 32 public:
33 ContextGroupTest() { 33 ContextGroupTest() : bind_generates_resource_(false) {}
34 }
35 34
36 protected: 35 protected:
37 virtual void SetUp() { 36 virtual void SetUp() {
38 gl_.reset(new ::testing::StrictMock< ::gfx::MockGLInterface>()); 37 gl_.reset(new ::testing::StrictMock< ::gfx::MockGLInterface>());
39 ::gfx::MockGLInterface::SetGLInterface(gl_.get()); 38 ::gfx::MockGLInterface::SetGLInterface(gl_.get());
40 decoder_.reset(new MockGLES2Decoder()); 39 decoder_.reset(new MockGLES2Decoder());
41 group_ = scoped_refptr<ContextGroup>( 40 group_ = scoped_refptr<ContextGroup>(new ContextGroup(
42 new ContextGroup(NULL, NULL, NULL, NULL, NULL, true)); 41 NULL, NULL, NULL, NULL, NULL, bind_generates_resource_));
43 } 42 }
44 43
45 virtual void TearDown() { 44 virtual void TearDown() {
46 ::gfx::MockGLInterface::SetGLInterface(NULL); 45 ::gfx::MockGLInterface::SetGLInterface(NULL);
47 gl_.reset(); 46 gl_.reset();
48 } 47 }
49 48
50 scoped_ptr< ::testing::StrictMock< ::gfx::MockGLInterface> > gl_; 49 scoped_ptr< ::testing::StrictMock< ::gfx::MockGLInterface> > gl_;
51 scoped_ptr<MockGLES2Decoder> decoder_; 50 scoped_ptr<MockGLES2Decoder> decoder_;
52 scoped_refptr<ContextGroup> group_; 51 scoped_refptr<ContextGroup> group_;
52 bool bind_generates_resource_;
piman 2014/04/04 02:50:28 is anything setting this to a non-default value?
vmiura 2014/04/04 18:32:57 Changed to kUseDefaultTextures.
piman 2014/04/04 22:47:44 I think you missed this file.
vmiura 2014/04/05 01:54:29 Done. Changed to kBindGeneratesResource.
53 }; 53 };
54 54
55 TEST_F(ContextGroupTest, Basic) { 55 TEST_F(ContextGroupTest, Basic) {
56 // Test it starts off uninitialized. 56 // Test it starts off uninitialized.
57 EXPECT_EQ(0u, group_->max_vertex_attribs()); 57 EXPECT_EQ(0u, group_->max_vertex_attribs());
58 EXPECT_EQ(0u, group_->max_texture_units()); 58 EXPECT_EQ(0u, group_->max_texture_units());
59 EXPECT_EQ(0u, group_->max_texture_image_units()); 59 EXPECT_EQ(0u, group_->max_texture_image_units());
60 EXPECT_EQ(0u, group_->max_vertex_texture_image_units()); 60 EXPECT_EQ(0u, group_->max_vertex_texture_image_units());
61 EXPECT_EQ(0u, group_->max_fragment_uniform_vectors()); 61 EXPECT_EQ(0u, group_->max_fragment_uniform_vectors());
62 EXPECT_EQ(0u, group_->max_varying_vectors()); 62 EXPECT_EQ(0u, group_->max_varying_vectors());
63 EXPECT_EQ(0u, group_->max_vertex_uniform_vectors()); 63 EXPECT_EQ(0u, group_->max_vertex_uniform_vectors());
64 EXPECT_TRUE(group_->buffer_manager() == NULL); 64 EXPECT_TRUE(group_->buffer_manager() == NULL);
65 EXPECT_TRUE(group_->framebuffer_manager() == NULL); 65 EXPECT_TRUE(group_->framebuffer_manager() == NULL);
66 EXPECT_TRUE(group_->renderbuffer_manager() == NULL); 66 EXPECT_TRUE(group_->renderbuffer_manager() == NULL);
67 EXPECT_TRUE(group_->texture_manager() == NULL); 67 EXPECT_TRUE(group_->texture_manager() == NULL);
68 EXPECT_TRUE(group_->program_manager() == NULL); 68 EXPECT_TRUE(group_->program_manager() == NULL);
69 EXPECT_TRUE(group_->shader_manager() == NULL); 69 EXPECT_TRUE(group_->shader_manager() == NULL);
70 } 70 }
71 71
72 TEST_F(ContextGroupTest, InitializeNoExtensions) { 72 TEST_F(ContextGroupTest, InitializeNoExtensions) {
73 TestHelper::SetupContextGroupInitExpectations(gl_.get(), 73 TestHelper::SetupContextGroupInitExpectations(
74 DisallowedFeatures(), "", ""); 74 gl_.get(), DisallowedFeatures(), "", "", bind_generates_resource_);
75 group_->Initialize(decoder_.get(), DisallowedFeatures()); 75 group_->Initialize(decoder_.get(), DisallowedFeatures());
76 EXPECT_EQ(static_cast<uint32>(TestHelper::kNumVertexAttribs), 76 EXPECT_EQ(static_cast<uint32>(TestHelper::kNumVertexAttribs),
77 group_->max_vertex_attribs()); 77 group_->max_vertex_attribs());
78 EXPECT_EQ(static_cast<uint32>(TestHelper::kNumTextureUnits), 78 EXPECT_EQ(static_cast<uint32>(TestHelper::kNumTextureUnits),
79 group_->max_texture_units()); 79 group_->max_texture_units());
80 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxTextureImageUnits), 80 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxTextureImageUnits),
81 group_->max_texture_image_units()); 81 group_->max_texture_image_units());
82 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxVertexTextureImageUnits), 82 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxVertexTextureImageUnits),
83 group_->max_vertex_texture_image_units()); 83 group_->max_vertex_texture_image_units());
84 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxFragmentUniformVectors), 84 EXPECT_EQ(static_cast<uint32>(TestHelper::kMaxFragmentUniformVectors),
(...skipping 13 matching lines...) Expand all
98 EXPECT_TRUE(group_->buffer_manager() == NULL); 98 EXPECT_TRUE(group_->buffer_manager() == NULL);
99 EXPECT_TRUE(group_->framebuffer_manager() == NULL); 99 EXPECT_TRUE(group_->framebuffer_manager() == NULL);
100 EXPECT_TRUE(group_->renderbuffer_manager() == NULL); 100 EXPECT_TRUE(group_->renderbuffer_manager() == NULL);
101 EXPECT_TRUE(group_->texture_manager() == NULL); 101 EXPECT_TRUE(group_->texture_manager() == NULL);
102 EXPECT_TRUE(group_->program_manager() == NULL); 102 EXPECT_TRUE(group_->program_manager() == NULL);
103 EXPECT_TRUE(group_->shader_manager() == NULL); 103 EXPECT_TRUE(group_->shader_manager() == NULL);
104 } 104 }
105 105
106 TEST_F(ContextGroupTest, MultipleContexts) { 106 TEST_F(ContextGroupTest, MultipleContexts) {
107 scoped_ptr<MockGLES2Decoder> decoder2_(new MockGLES2Decoder()); 107 scoped_ptr<MockGLES2Decoder> decoder2_(new MockGLES2Decoder());
108 TestHelper::SetupContextGroupInitExpectations(gl_.get(), 108 TestHelper::SetupContextGroupInitExpectations(
109 DisallowedFeatures(), "", ""); 109 gl_.get(), DisallowedFeatures(), "", "", bind_generates_resource_);
110 group_->Initialize(decoder_.get(), DisallowedFeatures()); 110 group_->Initialize(decoder_.get(), DisallowedFeatures());
111 group_->Initialize(decoder2_.get(), DisallowedFeatures()); 111 group_->Initialize(decoder2_.get(), DisallowedFeatures());
112 112
113 EXPECT_TRUE(group_->buffer_manager() != NULL); 113 EXPECT_TRUE(group_->buffer_manager() != NULL);
114 EXPECT_TRUE(group_->framebuffer_manager() != NULL); 114 EXPECT_TRUE(group_->framebuffer_manager() != NULL);
115 EXPECT_TRUE(group_->renderbuffer_manager() != NULL); 115 EXPECT_TRUE(group_->renderbuffer_manager() != NULL);
116 EXPECT_TRUE(group_->texture_manager() != NULL); 116 EXPECT_TRUE(group_->texture_manager() != NULL);
117 EXPECT_TRUE(group_->program_manager() != NULL); 117 EXPECT_TRUE(group_->program_manager() != NULL);
118 EXPECT_TRUE(group_->shader_manager() != NULL); 118 EXPECT_TRUE(group_->shader_manager() != NULL);
119 119
(...skipping 13 matching lines...) Expand all
133 EXPECT_TRUE(group_->renderbuffer_manager() == NULL); 133 EXPECT_TRUE(group_->renderbuffer_manager() == NULL);
134 EXPECT_TRUE(group_->texture_manager() == NULL); 134 EXPECT_TRUE(group_->texture_manager() == NULL);
135 EXPECT_TRUE(group_->program_manager() == NULL); 135 EXPECT_TRUE(group_->program_manager() == NULL);
136 EXPECT_TRUE(group_->shader_manager() == NULL); 136 EXPECT_TRUE(group_->shader_manager() == NULL);
137 } 137 }
138 138
139 } // namespace gles2 139 } // namespace gles2
140 } // namespace gpu 140 } // namespace gpu
141 141
142 142
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698