Revert HTTP/0.9 removal (https://codereview.chromium.org/2144803002/)

Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
Committed: https://crrev.com/a2dcd3bf444490b1eaf7aaafaa740310dc846137
Cr-Commit-Position: refs/heads/master@{#412348}

[mmenke, 2016-08-15 20:37:32]

Description was changed from

==========
Revert HTTP/0.9 removal (https://codereview.chromium.org/2144803002/)

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

BUG=637017

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}
==========

[mmenke, 2016-08-15 20:37:32]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org, jwd@chromium.org, ricea@chromium.org

[mmenke, 2016-08-15 20:38:13]

Just a straight of the original CL, so TBRing.

[mmenke, 2016-08-15 20:39:02]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:39:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-08-15 20:39:30]

Description was changed from

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017


Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}
==========

[mmenke, 2016-08-15 20:39:58]

Description was changed from

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017


Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

[mmenke, 2016-08-15 21:14:05]

Description was changed from

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug).  We're going to go with a less
aggressive deprecation instead, at least for now - just supporting
HTTP/0.9 on default ports only.

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

[eroman, 2016-08-15 21:40:05]

https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:85647: +  <int value="214"
label="CERT_END"/>
not LGTM for the histograms.xml change.

* Don't take out CT_REQUIRED
* Should probably leave in INVALID_HTTP_RESPONSE and just mark it deprecated.

[mmenke, 2016-08-15 21:40:35]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2016-08-15 21:40:56]

On 2016/08/15 21:40:05, eroman wrote:
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:85647: +  <int value="214"
> label="CERT_END"/>
> not LGTM for the histograms.xml change.
> 
> * Don't take out CT_REQUIRED
> * Should probably leave in INVALID_HTTP_RESPONSE and just mark it deprecated.

Oops, thanks for catching that, will do!

[mmenke, 2016-08-15 21:41:50]

On 2016/08/15 21:40:56, mmenke wrote:
> On 2016/08/15 21:40:05, eroman wrote:
> >
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> > File tools/metrics/histograms/histograms.xml (right):
> > 
> >
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> > tools/metrics/histograms/histograms.xml:85647: +  <int value="214"
> > label="CERT_END"/>
> > not LGTM for the histograms.xml change.
> > 
> > * Don't take out CT_REQUIRED
> > * Should probably leave in INVALID_HTTP_RESPONSE and just mark it
deprecated.
> 
> Oops, thanks for catching that, will do!

I think I'll just leave them in everywhere, non-deprecated, as I'll be reusing
them, anyways.

[mmenke, 2016-08-16 16:28:37]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 16:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-08-16 16:29:01]

On 2016/08/15 21:40:05, eroman wrote:
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2247003003/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:85647: +  <int value="214"
> label="CERT_END"/>
> not LGTM for the histograms.xml change.
> 
> * Don't take out CT_REQUIRED
> * Should probably leave in INVALID_HTTP_RESPONSE and just mark it deprecated.

I've added back the new error code (Which isn't used, but will be, when I force
HTTP/0.9 only on default ports).  PTAL.

[commit-bot: I haz the power, 2016-08-16 18:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 18:53:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2016-08-16 19:12:48]

lgtm

[mmenke, 2016-08-16 19:13:44]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-16 19:14:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:50:03]

Description was changed from

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

[commit-bot: I haz the power, 2016-08-16 21:50:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 21:52:48]

Description was changed from

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}


TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017
==========

to

==========
Revert HTTP/0.9 removal

This broke compatibility with the Tenda D301 router, which is using
HTTP/0.9 (Presumably because of a bug in the router's firmare).
We're going to go with a less aggressive deprecation instead, at least
for now - we'll just support HTTP/0.9 on default ports only.

I'll try to be more aggressive in future Chrome releases (No HTTP/0.9
over SSL, for instance).

Reverted CL description:
 Remove HTTP/0.9 support from HttpStreamParser.

 HTTP/0.9 is an ancient protocol with some fundamental design problems.
 This CL remove support for it, while leaving most of the code needed to
 support HTTP/0.9 in place, in case this has to be reverted late in the
 game, or we decide to add a (temporary) enterprise policy to enable it.

 BUG=624462
 Committed: https://crrev.com/e2172e4b83ad33aef354618ce2e092db85baee1d
 Cr-Commit-Position: refs/heads/master@{#405687}

TBR=eroman@chromium.org, ricea@chromium.org,  jwd@chromium.org
BUG=637017

Committed: https://crrev.com/a2dcd3bf444490b1eaf7aaafaa740310dc846137
Cr-Commit-Position: refs/heads/master@{#412348}
==========

[commit-bot: I haz the power, 2016-08-16 21:52:49]

Patchset 2 (id:??) landed as
https://crrev.com/a2dcd3bf444490b1eaf7aaafaa740310dc846137
Cr-Commit-Position: refs/heads/master@{#412348}

[Adam Rice, 2016-08-17 02:21:51]

lgtm