Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462, 637017
Committed: https://crrev.com/398c105ea8391473126021104554d70fda08324b
Cr-Commit-Position: refs/heads/master@{#415643}
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/274482)
2 years, 6 months ago
(2016-08-16 19:05:08 UTC)
#4
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/212471) ios-device on ...
2 years, 5 months ago
(2016-08-23 21:28:17 UTC)
#8
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/223475) mac_chromium_compile_dbg_ng on ...
2 years, 5 months ago
(2016-08-23 22:05:19 UTC)
#12
Eroman: PTAL. If this makes it successfully to stable, I'm thinking I'll try and remove ...
2 years, 5 months ago
(2016-08-29 20:37:52 UTC)
#21
Eroman: PTAL. If this makes it successfully to stable, I'm thinking I'll try
and remove HTTP/0.9 support over SSL connections, though that may run into
issues with talking to HTTP/0.9 servers over SSL proxies.
mmenke
Description was changed from ========== Only allow HTTP/0.9 support on default ports. BUG=624462,637017 ========== to ...
2 years, 5 months ago
(2016-08-29 20:38:31 UTC)
#22
Description was changed from
==========
Only allow HTTP/0.9 support on default ports.
BUG=624462,637017
==========
to
==========
Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462,637017
==========
mmenke
The CQ bit was unchecked by mmenke@chromium.org
2 years, 5 months ago
(2016-08-29 20:39:02 UTC)
#23
lgtm. that is an impressive amount of plumbing needed! https://codereview.chromium.org/2253653002/diff/140001/chrome/browser/net/errorpage_browsertest.cc File chrome/browser/net/errorpage_browsertest.cc (right): https://codereview.chromium.org/2253653002/diff/140001/chrome/browser/net/errorpage_browsertest.cc#newcode1531 chrome/browser/net/errorpage_browsertest.cc:1531: ...
2 years, 5 months ago
(2016-08-29 22:11:55 UTC)
#24
Thanks, Eric! https://codereview.chromium.org/2253653002/diff/140001/chrome/browser/net/errorpage_browsertest.cc File chrome/browser/net/errorpage_browsertest.cc (right): https://codereview.chromium.org/2253653002/diff/140001/chrome/browser/net/errorpage_browsertest.cc#newcode1531 chrome/browser/net/errorpage_browsertest.cc:1531: // Make sure HTTP/0.9 is works on ...
2 years, 5 months ago
(2016-08-30 17:50:47 UTC)
#27
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/60825) ios-simulator on ...
2 years, 5 months ago
(2016-08-30 17:52:55 UTC)
#31
2 years, 5 months ago
(2016-08-30 19:32:01 UTC)
#35
Dry run: This issue passed the CQ dry run.
Steven Holte
histograms lgtm
2 years, 5 months ago
(2016-08-30 22:13:39 UTC)
#36
histograms lgtm
pastarmovj
lgtm with two nits. https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/policy/policy_test_cases.json File chrome/test/data/policy/policy_test_cases.json (right): https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/policy/policy_test_cases.json#newcode158 chrome/test/data/policy/policy_test_cases.json:158: "Http09OnNonDefaultPortsEnabled": { You can as ...
2 years, 5 months ago
(2016-08-31 12:02:12 UTC)
#37
Thanks for catching those! https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/policy/policy_test_cases.json File chrome/test/data/policy/policy_test_cases.json (right): https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/policy/policy_test_cases.json#newcode158 chrome/test/data/policy/policy_test_cases.json:158: "Http09OnNonDefaultPortsEnabled": { On 2016/08/31 12:02:11, ...
2 years, 5 months ago
(2016-08-31 14:30:29 UTC)
#38
Thanks for catching those!
https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/polic...
File chrome/test/data/policy/policy_test_cases.json (right):
https://codereview.chromium.org/2253653002/diff/180001/chrome/test/data/polic...
chrome/test/data/policy/policy_test_cases.json:158:
"Http09OnNonDefaultPortsEnabled": {
On 2016/08/31 12:02:11, pastarmovj wrote:
> You can as well leave the braces empty as nothing is tested here right now. If
> there is a corresponding pref (I think there isn't) or some UI in the settings
> that is changed when this policy is triggered it can be tested here but
> otherwise leaving just
>
> "Http09OnNonDefaultPortsEnabled": {}
>
> to satisfy the presubmit is good enough.
Done (Yea, there's no pref, no UI surface area)
https://codereview.chromium.org/2253653002/diff/180001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):
https://codereview.chromium.org/2253653002/diff/180001/components/policy/reso...
components/policy/resources/policy_templates.json:542: 'label': '''List of
disabled protocol schemes''',
On 2016/08/31 12:02:12, pastarmovj wrote:
> Please fix the label - this seems to have slipped from copying the one above.
:)
Done (Just removed it, so it defaults to the caption)
mmenke
The CQ bit was checked by mmenke@chromium.org
2 years, 5 months ago
(2016-08-31 14:30:51 UTC)
#39
Description was changed from ========== Only allow HTTP/0.9 support on default ports. Also add a ...
2 years, 5 months ago
(2016-08-31 16:07:17 UTC)
#42
Message was sent while issue was closed.
Description was changed from
==========
Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462,637017
==========
to
==========
Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462,637017
==========
commit-bot: I haz the power
Committed patchset #8 (id:200001)
2 years, 5 months ago
(2016-08-31 16:07:19 UTC)
#43
Message was sent while issue was closed.
Committed patchset #8 (id:200001)
commit-bot: I haz the power
Description was changed from ========== Only allow HTTP/0.9 support on default ports. Also add a ...
2 years, 5 months ago
(2016-08-31 16:08:40 UTC)
#44
Message was sent while issue was closed.
Description was changed from
==========
Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462,637017
==========
to
==========
Only allow HTTP/0.9 support on default ports.
Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.
BUG=624462,637017
Committed: https://crrev.com/398c105ea8391473126021104554d70fda08324b
Cr-Commit-Position: refs/heads/master@{#415643}
==========
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/398c105ea8391473126021104554d70fda08324b Cr-Commit-Position: refs/heads/master@{#415643}
2 years, 5 months ago
(2016-08-31 16:08:41 UTC)
#45
Issue 2253653002: Only allow HTTP/0.9 support on default ports.
(Closed)
Created 2 years, 6 months ago by mmenke
Modified 2 years, 5 months ago
Reviewers: eroman, pastarmovj, Steven Holte
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 14