Add CHECKs to investigate ResourceThrottle crash.

Add CHECKs to investigate ResourceThrottle crash.

BUG=640545
Committed: https://crrev.com/25d0501e6e9cf23cda9ea26a1b380dbbb4db0ba3
Cr-Commit-Position: refs/heads/master@{#414899}

[mmenke, 2016-08-24 21:45:15]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 21:46:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:51:22]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmenke, 2016-08-24 21:59:29]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:13:34]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[mmenke, 2016-08-24 22:55:37]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:56:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:13:21]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2016-08-25 17:59:02]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:15:33]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mmenke, 2016-08-25 18:29:34]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[mmenke, 2016-08-25 18:29:45]

Patchset #4 (id:60001) has been deleted

[mmenke, 2016-08-25 18:29:51]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-08-25 18:30:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:52:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mmenke, 2016-08-25 22:34:34]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:35:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-08-25 22:50:32]

Patchset #5 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-08-26 00:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:38:05]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-08-26 15:09:49]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 15:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 15:54:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mmenke, 2016-08-26 16:36:37]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 16:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-08-26 17:27:59]

Description was changed from

==========
Add code to investigate crash

BUG=
==========

to

==========
Add code to investigate ResourceThrottle crash

BUG=640545
==========

[mmenke, 2016-08-26 17:31:10]

Description was changed from

==========
Add code to investigate ResourceThrottle crash

BUG=640545
==========

to

==========
Add CHECKs to investigate ResourceThrottle crash.

BUG=640545
==========

[mmenke, 2016-08-26 17:32:20]

mmenke@chromium.org changed reviewers:
+ csharrison@chromium.org

[mmenke, 2016-08-26 17:32:21]

Planning on merging this to M54.  May keep it around a while, because of how
rare the crash normally is.

[Charlie Harrison, 2016-08-26 17:38:09]

Would it be useful to set up stack aliases / crash keys for when these CHECKs
occur?

[mmenke, 2016-08-26 17:57:40]

On 2016/08/26 17:38:09, Charlie Harrison wrote:
> Would it be useful to set up stack aliases / crash keys for when these CHECKs
> occur?

So if we're being destroyed by a ResourceThrottle, I'm thinking the call graph
should be enough...That having been said, it looks like we can grab the name of
the buggy ResourceThrottle, and toss it on the stack, just in case.  And I've
tossed in a couple other things, though they're less likely to be useful, I
think.

Crash keys?

[mmenke, 2016-08-26 18:02:45]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:03:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:13:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Charlie Harrison, 2016-08-26 18:14:50]

https://codereview.chromium.org/2271403002/diff/240001/content/browser/loader...
File content/browser/loader/throttling_resource_handler.cc (right):

https://codereview.chromium.org/2271403002/diff/240001/content/browser/loader...
content/browser/loader/throttling_resource_handler.cc:46:
sizeof(bad_throttle_name));
Here you use sizeof but below you use arraysize. Let's be consistent.

[mmenke, 2016-08-26 18:17:10]

Patchset #11 (id:260001) has been deleted

[mmenke, 2016-08-26 18:17:20]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[mmenke, 2016-08-26 18:17:58]

Thanks!

https://codereview.chromium.org/2271403002/diff/240001/content/browser/loader...
File content/browser/loader/throttling_resource_handler.cc (right):

https://codereview.chromium.org/2271403002/diff/240001/content/browser/loader...
content/browser/loader/throttling_resource_handler.cc:46:
sizeof(bad_throttle_name));
On 2016/08/26 18:14:50, Charlie Harrison wrote:
> Here you use sizeof but below you use arraysize. Let's be consistent.

oops.  Switched to arraysize, seems more consistent with strlcpy.

[commit-bot: I haz the power, 2016-08-26 18:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-08-26 18:35:49]

lgtm

[mmenke, 2016-08-26 18:53:16]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2016-08-26 18:53:24]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:54:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:04:43]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2016-08-26 20:15:09]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:30:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mmenke, 2016-08-26 22:54:06]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:54:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:46:26]

Description was changed from

==========
Add CHECKs to investigate ResourceThrottle crash.

BUG=640545
==========

to

==========
Add CHECKs to investigate ResourceThrottle crash.

BUG=640545
==========

[commit-bot: I haz the power, 2016-08-27 10:46:29]

Committed patchset #11 (id:280001)

[commit-bot: I haz the power, 2016-08-27 10:49:52]

Description was changed from

==========
Add CHECKs to investigate ResourceThrottle crash.

BUG=640545
==========

to

==========
Add CHECKs to investigate ResourceThrottle crash.

BUG=640545

Committed: https://crrev.com/25d0501e6e9cf23cda9ea26a1b380dbbb4db0ba3
Cr-Commit-Position: refs/heads/master@{#414899}
==========

[commit-bot: I haz the power, 2016-08-27 10:49:54]

Patchset 11 (id:??) landed as
https://crrev.com/25d0501e6e9cf23cda9ea26a1b380dbbb4db0ba3
Cr-Commit-Position: refs/heads/master@{#414899}

[mmenke, 2016-09-21 19:46:00]

A revert of this CL (patchset #11 id:280001) has been created in
https://codereview.chromium.org/2357173003/ by mmenke@chromium.org.

The reason for reverting is: Figured out the issue, these are no longer needed..