Drop unwanted dependencies on chromium_tests recipe module

Drop unwanted dependencies on chromium_tests recipe module

ios and webrtc are not ready to move to chromium/src yet,
which would otherwise be required to move chromium_tests there.

See https://codereview.chromium.org/2146873002 and
https://codereview.chromium.org/2147913002 for similar CLs
from the past.

BUG=584079, 593999
Committed: https://chromium.googlesource.com/chromium/tools/build/+/b83c98d76351019efcf66ed6b8c613aa5a84e815

[Paweł Hajdan Jr., 2016-08-12 12:35:06]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 12:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 12:39:01]

Dry run: Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/309793458f29f010)

[Paweł Hajdan Jr., 2016-08-12 12:51:04]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 12:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 12:55:22]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-08-12 12:59:30]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Sergiy Byelozyorov, 2016-08-12 13:22:25]

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_checkout/api.py (right):

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_checkout/api.py:19: Requires
|ensure_checkout| to be called first.
perhaps add an assert?

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_checkout/api.py:48: cwd =
self.working_dir.join(patch_root)
This would require having working_dir initialized... previously, in
chromium_tests, cwd was assigned to None if this is not the case. Are you sure
that all callers of chromium_tests.get_files_affacted_by_patch are calling
ensure_checkout prior to this? If so, please document this like you did for
get_checkout_dir and add an assert.

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/api.py:670: return
self.m.chromium_checkout.get_files_affected_by_patch(  # pragma: no cover
nit: 80 chars, move pragma comment to the next line

[Sergiy Byelozyorov, 2016-08-12 13:41:41]

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_checkout/api.py (right):

https://codereview.chromium.org/2243853002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_checkout/api.py:48: cwd =
self.working_dir.join(patch_root)
On 2016/08/12 13:22:24, Sergiy Byelozyorov wrote:
> This would require having working_dir initialized... previously, in
> chromium_tests, cwd was assigned to None if this is not the case. Are you sure
> that all callers of chromium_tests.get_files_affacted_by_patch are calling
> ensure_checkout prior to this? If so, please document this like you did for
> get_checkout_dir and add an assert.

As Pawel pointed out, the if self._working_dir check has moved into condition on
the previous line.

[Sergiy Byelozyorov, 2016-08-12 13:45:03]

lgtm

Pawel pointed out that adding asserts both in working_dir and
get_files_affected_by_patch methods is not desired since they are used in other
modules which may violate this condition atm.

[Paweł Hajdan Jr., 2016-08-12 13:50:46]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-08-12 13:50:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/2243853002/#ps40001
(title: "TODO")

[commit-bot: I haz the power, 2016-08-12 13:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 13:55:12]

Description was changed from

==========
Drop unwanted dependencies on chromium_tests recipe module

ios and webrtc are not ready to move to chromium/src yet,
which would otherwise be required to move chromium_tests there.

See https://codereview.chromium.org/2146873002 and
https://codereview.chromium.org/2147913002 for similar CLs
from the past.

BUG=584079, 593999
==========

to

==========
Drop unwanted dependencies on chromium_tests recipe module

ios and webrtc are not ready to move to chromium/src yet,
which would otherwise be required to move chromium_tests there.

See https://codereview.chromium.org/2146873002 and
https://codereview.chromium.org/2147913002 for similar CLs
from the past.

BUG=584079, 593999

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b83c98d76351019efcf6...
==========

[commit-bot: I haz the power, 2016-08-12 13:55:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/b83c98d76351019efcf6...