Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: scripts/slave/recipes/blink_downstream.py

Issue 2243853002: Drop unwanted dependencies on chromium_tests recipe module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: TODO Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipe_modules/webrtc/api.py ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 This recipe can be used by components like v8 to verify blink tests with a 6 This recipe can be used by components like v8 to verify blink tests with a
7 low false positive rate. Similar to a trybot, this recipe compares test 7 low false positive rate. Similar to a trybot, this recipe compares test
8 failures from a build with a current component revision with test failures 8 failures from a build with a current component revision with test failures
9 from a build with a pinned component revision. 9 from a build with a pinned component revision.
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 Revision Y will be the revision property as provided by buildbot or HEAD (i.e. 24 Revision Y will be the revision property as provided by buildbot or HEAD (i.e.
25 in a forced build with no revision provided). 25 in a forced build with no revision provided).
26 """ 26 """
27 27
28 from recipe_engine.types import freeze 28 from recipe_engine.types import freeze
29 29
30 DEPS = [ 30 DEPS = [
31 'depot_tools/bot_update', 31 'depot_tools/bot_update',
32 'chromium', 32 'chromium',
33 'chromium_checkout',
33 'chromium_tests', 34 'chromium_tests',
34 'depot_tools/gclient', 35 'depot_tools/gclient',
35 'recipe_engine/json', 36 'recipe_engine/json',
36 'recipe_engine/path', 37 'recipe_engine/path',
37 'recipe_engine/platform', 38 'recipe_engine/platform',
38 'recipe_engine/properties', 39 'recipe_engine/properties',
39 'recipe_engine/python', 40 'recipe_engine/python',
40 'recipe_engine/raw_io', 41 'recipe_engine/raw_io',
41 'recipe_engine/step', 42 'recipe_engine/step',
42 'test_utils', 43 'test_utils',
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 126
126 # Sync component to current component revision. 127 # Sync component to current component revision.
127 component_revision = api.properties.get('revision') or 'HEAD' 128 component_revision = api.properties.get('revision') or 'HEAD'
128 api.gclient.c.revisions[bot_config['component']['path']] = ( 129 api.gclient.c.revisions[bot_config['component']['path']] = (
129 bot_config['component']['revision'] % component_revision) 130 bot_config['component']['revision'] % component_revision)
130 131
131 # Ensure we remember the chromium revision. 132 # Ensure we remember the chromium revision.
132 api.gclient.c.got_revision_mapping['src'] = 'got_cr_revision' 133 api.gclient.c.got_revision_mapping['src'] = 'got_cr_revision'
133 134
134 context = {} 135 context = {}
135 checkout_dir = api.chromium_tests.get_checkout_dir(bot_config) 136 checkout_dir = api.chromium_checkout.get_checkout_dir(bot_config)
136 if checkout_dir: 137 if checkout_dir:
137 context['cwd'] = checkout_dir 138 context['cwd'] = checkout_dir
138 139
139 # Run all steps in the checkout dir (consistent with chromium_tests). 140 # Run all steps in the checkout dir (consistent with chromium_tests).
140 with api.step.context(context): 141 with api.step.context(context):
141 # TODO(phajdan.jr): remove redundant **context below once we fix things 142 # TODO(phajdan.jr): remove redundant **context below once we fix things
142 # to behave the same without it. 143 # to behave the same without it.
143 step_result = api.bot_update.ensure_checkout(force=True, **context) 144 step_result = api.bot_update.ensure_checkout(force=True, **context)
144 145
145 api.chromium.ensure_goma() 146 api.chromium.ensure_goma()
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 # and compare the lists of failing tests). 268 # and compare the lists of failing tests).
268 yield ( 269 yield (
269 api.test('too_many_failures_for_retcode') + 270 api.test('too_many_failures_for_retcode') +
270 properties('client.v8.fyi', 'V8-Blink Linux 64') + 271 properties('client.v8.fyi', 'V8-Blink Linux 64') +
271 api.override_step_data(with_patch, 272 api.override_step_data(with_patch,
272 canned_test(passing=False, 273 canned_test(passing=False,
273 num_additional_failures=125)) + 274 num_additional_failures=125)) +
274 api.override_step_data(without_patch, 275 api.override_step_data(without_patch,
275 canned_test(passing=True, minimal=True)) 276 canned_test(passing=True, minimal=True))
276 ) 277 )
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/webrtc/api.py ('k') | scripts/slave/recipes/chromium_trybot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698