Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2147913002: webrtc: drop dependency on chromium_tests; extract chromium_swarming (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

webrtc: drop dependency on chromium_tests; extract chromium_swarming This will make it easier to move chromium_tests out of build repo. BUG=584079 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8ce4d7f4b246ac1b3487675d93e65f6ad6cc61d4

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -68 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/api.py View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipe_modules/chromium_swarming/__init__.py View 1 chunk +5 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/chromium_swarming/api.py View 1 chunk +71 lines, -0 lines 3 comments Download
M scripts/slave/recipe_modules/chromium_tests/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 3 chunks +3 lines, -61 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/findit/chromium/test.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-13 10:34:40 UTC) #2
tandrii(chromium)
LGTM % comment, though ideally for another CL https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py File scripts/slave/recipe_modules/chromium_swarming/api.py (right): https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py#newcode56 scripts/slave/recipe_modules/chromium_swarming/api.py:56: if ...
4 years, 5 months ago (2016-07-13 11:27:03 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py File scripts/slave/recipe_modules/chromium_swarming/api.py (right): https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py#newcode56 scripts/slave/recipe_modules/chromium_swarming/api.py:56: if requester == 'commit-bot@chromium.org': On 2016/07/13 at 11:27:03, tandrii(chromium) ...
4 years, 5 months ago (2016-07-13 11:28:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147913002/1
4 years, 5 months ago (2016-07-13 11:28:14 UTC) #10
tandrii(chromium)
https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py File scripts/slave/recipe_modules/chromium_swarming/api.py (right): https://codereview.chromium.org/2147913002/diff/1/scripts/slave/recipe_modules/chromium_swarming/api.py#newcode56 scripts/slave/recipe_modules/chromium_swarming/api.py:56: if requester == 'commit-bot@chromium.org': On 2016/07/13 11:28:03, Paweł Hajdan ...
4 years, 5 months ago (2016-07-13 11:30:57 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 11:32:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8ce4d7f4b246ac1b3487...

Powered by Google App Engine
This is Rietveld 408576698