Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make FXJS_GetObjectElement return std::vector<CFX_WideString>. Analogous to getting the length of JS array, this result should be a C++-side object only. Also rename to FXJS_GetObjectProperty to match JS nomenclature. Committed: https://pdfium.googlesource.com/pdfium/+/d0b6ed1a0842386e474c5fcd6bdbb260bb631bd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M fpdfsdk/javascript/Document.cpp View 2 chunks +11 lines, -10 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M fxjs/fxjs_v8.cpp View 2 chunks +15 lines, -6 lines 0 comments Download
M fxjs/fxjs_v8_embeddertest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fxjs/include/fxjs_v8.h View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, small steps for review.
4 years, 4 months ago (2016-08-11 21:18:49 UTC) #5
dsinclair
lgtm
4 years, 4 months ago (2016-08-12 02:50:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242593002/1
4 years, 4 months ago (2016-08-12 02:50:42 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 02:51:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d0b6ed1a0842386e474c5fcd6bdbb260bb63...

Powered by Google App Engine
This is Rietveld 408576698