fpdfsdk/javascript/JS_Value.cpp - Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_Value.cpp

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/JS_Value.cpp

diff --git a/fpdfsdk/javascript/JS_Value.cpp b/fpdfsdk/javascript/JS_Value.cpp

index 8f448a9d9e8c4b0a6a05bea9393c8cdc9bec1804..b7198353da67a57be581d00dc070e21348e86b5e 100644

--- a/fpdfsdk/javascript/JS_Value.cpp

+++ b/fpdfsdk/javascript/JS_Value.cpp

@@ -771,7 +771,7 @@ std::vector<CJS_Value> JS_ExpandKeywordParams(

for (size_t i = 0; i < nKeywords; ++i) {

const wchar_t* property = va_arg(ap, const wchar_t*);

v8::Local<v8::Value> v8Value =

- FXJS_GetObjectElement(pRuntime->GetIsolate(), pObj, property);

+ FXJS_GetObjectProperty(pRuntime->GetIsolate(), pObj, property);

if (!v8Value->IsUndefined())

result[i] = CJS_Value(pRuntime, v8Value);

}

« no previous file with comments | « fpdfsdk/javascript/Document.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »