Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: fpdfsdk/javascript/JS_Value.cpp

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/javascript/Document.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/javascript/JS_Value.h" 7 #include "fpdfsdk/javascript/JS_Value.h"
8 8
9 #include <time.h> 9 #include <time.h>
10 10
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 return result; 764 return result;
765 } 765 }
766 v8::Local<v8::Object> pObj = originals[0].ToV8Object(pRuntime->GetIsolate()); 766 v8::Local<v8::Object> pObj = originals[0].ToV8Object(pRuntime->GetIsolate());
767 result[0] = CJS_Value(pRuntime); // Make unknown. 767 result[0] = CJS_Value(pRuntime); // Make unknown.
768 768
769 va_list ap; 769 va_list ap;
770 va_start(ap, nKeywords); 770 va_start(ap, nKeywords);
771 for (size_t i = 0; i < nKeywords; ++i) { 771 for (size_t i = 0; i < nKeywords; ++i) {
772 const wchar_t* property = va_arg(ap, const wchar_t*); 772 const wchar_t* property = va_arg(ap, const wchar_t*);
773 v8::Local<v8::Value> v8Value = 773 v8::Local<v8::Value> v8Value =
774 FXJS_GetObjectElement(pRuntime->GetIsolate(), pObj, property); 774 FXJS_GetObjectProperty(pRuntime->GetIsolate(), pObj, property);
775 if (!v8Value->IsUndefined()) 775 if (!v8Value->IsUndefined())
776 result[i] = CJS_Value(pRuntime, v8Value); 776 result[i] = CJS_Value(pRuntime, v8Value);
777 } 777 }
778 va_end(ap); 778 va_end(ap);
779 return result; 779 return result;
780 } 780 }
OLDNEW
« no previous file with comments | « fpdfsdk/javascript/Document.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698