Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: fxjs/fxjs_v8_embeddertest.cpp

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fxjs/fxjs_v8.cpp ('k') | fxjs/include/fxjs_v8.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "testing/gtest/include/gtest/gtest.h" 5 #include "testing/gtest/include/gtest/gtest.h"
6 #include "testing/js_embedder_test.h" 6 #include "testing/js_embedder_test.h"
7 7
8 namespace { 8 namespace {
9 9
10 const double kExpected0 = 6.0; 10 const double kExpected0 = 6.0;
11 const double kExpected1 = 7.0; 11 const double kExpected1 = 7.0;
12 const double kExpected2 = 8.0; 12 const double kExpected2 = 8.0;
13 13
14 const wchar_t kScript0[] = L"fred = 6"; 14 const wchar_t kScript0[] = L"fred = 6";
15 const wchar_t kScript1[] = L"fred = 7"; 15 const wchar_t kScript1[] = L"fred = 7";
16 const wchar_t kScript2[] = L"fred = 8"; 16 const wchar_t kScript2[] = L"fred = 8";
17 17
18 } // namespace 18 } // namespace
19 19
20 class FXJSV8EmbedderTest : public JSEmbedderTest { 20 class FXJSV8EmbedderTest : public JSEmbedderTest {
21 public: 21 public:
22 void ExecuteInCurrentContext(const CFX_WideString& script) { 22 void ExecuteInCurrentContext(const CFX_WideString& script) {
23 FXJSErr error; 23 FXJSErr error;
24 int sts = FXJS_Execute(isolate(), script, &error); 24 int sts = FXJS_Execute(isolate(), script, &error);
25 EXPECT_EQ(0, sts); 25 EXPECT_EQ(0, sts);
26 } 26 }
27 void CheckAssignmentInCurrentContext(double expected) { 27 void CheckAssignmentInCurrentContext(double expected) {
28 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate()); 28 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
29 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred"); 29 v8::Local<v8::Value> fred =
30 FXJS_GetObjectProperty(isolate(), This, L"fred");
30 EXPECT_TRUE(fred->IsNumber()); 31 EXPECT_TRUE(fred->IsNumber());
31 EXPECT_EQ(expected, fred->ToNumber(isolate()->GetCurrentContext()) 32 EXPECT_EQ(expected, fred->ToNumber(isolate()->GetCurrentContext())
32 .ToLocalChecked() 33 .ToLocalChecked()
33 ->Value()); 34 ->Value());
34 } 35 }
35 }; 36 };
36 37
37 TEST_F(FXJSV8EmbedderTest, Getters) { 38 TEST_F(FXJSV8EmbedderTest, Getters) {
38 v8::Isolate::Scope isolate_scope(isolate()); 39 v8::Isolate::Scope isolate_scope(isolate());
39 v8::HandleScope handle_scope(isolate()); 40 v8::HandleScope handle_scope(isolate());
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 v8::Local<v8::Context> context2 = 75 v8::Local<v8::Context> context2 =
75 v8::Local<v8::Context>::New(isolate(), global_context2); 76 v8::Local<v8::Context>::New(isolate(), global_context2);
76 v8::Context::Scope context_scope2(context2); 77 v8::Context::Scope context_scope2(context2);
77 ExecuteInCurrentContext(CFX_WideString(kScript2)); 78 ExecuteInCurrentContext(CFX_WideString(kScript2));
78 CheckAssignmentInCurrentContext(kExpected2); 79 CheckAssignmentInCurrentContext(kExpected2);
79 } 80 }
80 FXJS_ReleaseRuntime(isolate(), &global_context2, &static_objects2); 81 FXJS_ReleaseRuntime(isolate(), &global_context2, &static_objects2);
81 82
82 CheckAssignmentInCurrentContext(kExpected0); 83 CheckAssignmentInCurrentContext(kExpected0);
83 } 84 }
OLDNEW
« no previous file with comments | « fxjs/fxjs_v8.cpp ('k') | fxjs/include/fxjs_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698