Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224233003: Move vertex and fragment shader uniform vector workarounds to gpu driver bug list. (Closed)

Created:
6 years, 8 months ago by rptr
Modified:
6 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move vertex and fragment shader uniform vector workarounds to gpu driver bug list. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264215

Patch Set 1 #

Total comments: 2

Patch Set 2 : "review comments." #

Patch Set 3 : rebase #

Patch Set 4 : formatting.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M gpu/command_buffer/service/context_group.cc View 1 2 3 1 chunk +17 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rptr
PTAL.
6 years, 8 months ago (2014-04-03 17:48:53 UTC) #1
piman
https://chromiumcodereview.appspot.com/224233003/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://chromiumcodereview.appspot.com/224233003/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode929 gpu/config/gpu_driver_bug_list_json.cc:929: "value": "Mesa" Mmh, OSMesa isn't the same as all ...
6 years, 8 months ago (2014-04-03 19:59:33 UTC) #2
rptr
PTAL. https://chromiumcodereview.appspot.com/224233003/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://chromiumcodereview.appspot.com/224233003/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode929 gpu/config/gpu_driver_bug_list_json.cc:929: "value": "Mesa" On 2014/04/03 19:59:33, piman wrote: > ...
6 years, 8 months ago (2014-04-04 06:31:06 UTC) #3
piman
lgtm
6 years, 8 months ago (2014-04-04 14:50:08 UTC) #4
rptr
rebase.
6 years, 8 months ago (2014-04-15 18:36:50 UTC) #5
rptr
The CQ bit was checked by puttaraju.r@samsung.com
6 years, 8 months ago (2014-04-16 02:54:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/puttaraju.r@samsung.com/224233003/30001
6 years, 8 months ago (2014-04-16 02:55:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 03:48:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61705
6 years, 8 months ago (2014-04-16 03:48:38 UTC) #9
rptr
The CQ bit was checked by puttaraju.r@samsung.com
6 years, 8 months ago (2014-04-16 10:57:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/puttaraju.r@samsung.com/224233003/50001
6 years, 8 months ago (2014-04-16 10:57:44 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 16:49:56 UTC) #12
Message was sent while issue was closed. 
Change committed as 264215

Powered by Google App Engine
This is Rietveld 408576698