Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2240223002: Add contentDescription to offline badges on the NTP (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add contentDescription to offline badges on the NTP BUG=606377 Committed: https://crrev.com/56637491ae161091eaf4a398d7ec353ee517919c Cr-Commit-Position: refs/heads/master@{#412196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/res/layout/most_visited_item.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Marc Treib
PTAL!
4 years, 4 months ago (2016-08-12 16:14:45 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 4 months ago (2016-08-13 11:58:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240223002/1
4 years, 4 months ago (2016-08-16 08:32:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 09:06:35 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 09:08:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56637491ae161091eaf4a398d7ec353ee517919c
Cr-Commit-Position: refs/heads/master@{#412196}

Powered by Google App Engine
This is Rietveld 408576698