chrome/android/java/res/layout/most_visited_item.xml - Issue 2240223002: Add contentDescription to offline badges on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/most_visited_item.xml

Issue 2240223002: Add contentDescription to offline badges on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jan

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/most_visited_item.xml

diff --git a/chrome/android/java/res/layout/most_visited_item.xml b/chrome/android/java/res/layout/most_visited_item.xml

index 56e5ec9f07dbc5bd4e810c8c4f82d1030743e13a..ad7125bcdf1de26d8cc35308900f7d4666b599e1 100644

--- a/chrome/android/java/res/layout/most_visited_item.xml

+++ b/chrome/android/java/res/layout/most_visited_item.xml

@@ -28,7 +28,7 @@

android:layout_marginStart="48dp"

android:visibility="gone"

android:background="@drawable/offline_badge_background"

- android:contentDescription="@null"

+ android:contentDescription="@string/accessibility_ntp_offline_badge"

chrome:tint="@color/most_visited_offline_badge_tint"

android:src="@drawable/offline_bolt" />

« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »