Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: chrome/android/java/res/layout/most_visited_item.xml

Issue 2240223002: Add contentDescription to offline badges on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jan
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- A most visited item, for display on the new tab page. --> 6 <!-- A most visited item, for display on the new tab page. -->
7 <org.chromium.chrome.browser.ntp.MostVisitedItemView 7 <org.chromium.chrome.browser.ntp.MostVisitedItemView
8 xmlns:android="http://schemas.android.com/apk/res/android" 8 xmlns:android="http://schemas.android.com/apk/res/android"
9 xmlns:chrome="http://schemas.android.com/apk/res-auto" 9 xmlns:chrome="http://schemas.android.com/apk/res-auto"
10 android:layout_width="@dimen/most_visited_tile_width" 10 android:layout_width="@dimen/most_visited_tile_width"
(...skipping 10 matching lines...) Expand all
21 android:layout_marginTop="12dp" 21 android:layout_marginTop="12dp"
22 android:contentDescription="@null" /> 22 android:contentDescription="@null" />
23 23
24 <org.chromium.chrome.browser.widget.TintedImageView 24 <org.chromium.chrome.browser.widget.TintedImageView
25 android:id="@+id/offline_badge" 25 android:id="@+id/offline_badge"
26 android:layout_width="@dimen/most_visited_offline_badge_size" 26 android:layout_width="@dimen/most_visited_offline_badge_size"
27 android:layout_height="@dimen/most_visited_offline_badge_size" 27 android:layout_height="@dimen/most_visited_offline_badge_size"
28 android:layout_marginStart="48dp" 28 android:layout_marginStart="48dp"
29 android:visibility="gone" 29 android:visibility="gone"
30 android:background="@drawable/offline_badge_background" 30 android:background="@drawable/offline_badge_background"
31 android:contentDescription="@null" 31 android:contentDescription="@string/accessibility_ntp_offline_badge"
32 chrome:tint="@color/most_visited_offline_badge_tint" 32 chrome:tint="@color/most_visited_offline_badge_tint"
33 android:src="@drawable/offline_bolt" /> 33 android:src="@drawable/offline_bolt" />
34 34
35 <View 35 <View
36 android:layout_width="@dimen/most_visited_icon_size" 36 android:layout_width="@dimen/most_visited_icon_size"
37 android:layout_height="@dimen/most_visited_icon_size" 37 android:layout_height="@dimen/most_visited_icon_size"
38 android:layout_marginStart="12dp" 38 android:layout_marginStart="12dp"
39 android:layout_marginEnd="12dp" 39 android:layout_marginEnd="12dp"
40 android:layout_marginTop="12dp" 40 android:layout_marginTop="12dp"
41 android:background="@drawable/most_visited_item_highlight" /> 41 android:background="@drawable/most_visited_item_highlight" />
42 42
43 <TextView 43 <TextView
44 android:id="@+id/most_visited_title" 44 android:id="@+id/most_visited_title"
45 android:layout_width="72dp" 45 android:layout_width="72dp"
46 android:layout_height="wrap_content" 46 android:layout_height="wrap_content"
47 android:layout_marginTop="66dp" 47 android:layout_marginTop="66dp"
48 android:ellipsize="end" 48 android:ellipsize="end"
49 android:gravity="center_horizontal" 49 android:gravity="center_horizontal"
50 android:lines="2" 50 android:lines="2"
51 android:lineSpacingMultiplier="1.17" 51 android:lineSpacingMultiplier="1.17"
52 android:textColor="@color/most_visited_text" 52 android:textColor="@color/most_visited_text"
53 android:textSize="12sp" /> 53 android:textSize="12sp" />
54 54
55 </org.chromium.chrome.browser.ntp.MostVisitedItemView> 55 </org.chromium.chrome.browser.ntp.MostVisitedItemView>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698