[Interpreter] Remove LdaConstant+ToName peephole optimization.

[Interpreter] Remove LdaConstant+ToName peephole optimization.

This optimization required access to the heap which we can't do off-thread.
There doesn't seem to be a regression without this optmization in anycase,
so just rip it out.

BUG=v8:5203
Committed: https://crrev.com/cda8387c89956609789f9b811836bb0714e9da93
Cr-Commit-Position: refs/heads/master@{#38585}

[rmcilroy, 2016-08-11 10:16:17]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 10:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmcilroy, 2016-08-11 10:17:49]

rmcilroy@chromium.org changed reviewers:
+ klaasb@google.com, mstarzinger@chromium.org

[rmcilroy, 2016-08-11 10:17:49]

Klaas / Michi, PTAL thanks.

[klaasb, 2016-08-11 10:48:00]

lgtm

[commit-bot: I haz the power, 2016-08-11 10:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 10:55:18]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-08-11 13:19:15]

LGTM, just nits.

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
File src/interpreter/bytecode-peephole-optimizer.cc (right):

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
src/interpreter/bytecode-peephole-optimizer.cc:7: #include
"src/interpreter/constant-array-builder.h"
nit: Header file inclusion should be obsolete. Lets drop it.

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
File src/interpreter/bytecode-peephole-optimizer.h (right):

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
src/interpreter/bytecode-peephole-optimizer.h:15: class ConstantArrayBuilder;
nit: Forward declaration should be obsolete. Lets drop it.

https://codereview.chromium.org/2238853002/diff/1/test/unittests/interpreter/...
File test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc (right):

https://codereview.chromium.org/2238853002/diff/1/test/unittests/interpreter/...
test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc:10: #include
"src/interpreter/constant-array-builder.h"
nit: Header file inclusion is obsolete. Lets drop it.

[rmcilroy, 2016-08-11 14:46:17]

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
File src/interpreter/bytecode-peephole-optimizer.cc (right):

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
src/interpreter/bytecode-peephole-optimizer.cc:7: #include
"src/interpreter/constant-array-builder.h"
On 2016/08/11 13:19:14, Michael Starzinger wrote:
> nit: Header file inclusion should be obsolete. Lets drop it.

Good catch, thanks. Done.

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
File src/interpreter/bytecode-peephole-optimizer.h (right):

https://codereview.chromium.org/2238853002/diff/1/src/interpreter/bytecode-pe...
src/interpreter/bytecode-peephole-optimizer.h:15: class ConstantArrayBuilder;
On 2016/08/11 13:19:14, Michael Starzinger wrote:
> nit: Forward declaration should be obsolete. Lets drop it.

Done.

https://codereview.chromium.org/2238853002/diff/1/test/unittests/interpreter/...
File test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc (right):

https://codereview.chromium.org/2238853002/diff/1/test/unittests/interpreter/...
test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc:10: #include
"src/interpreter/constant-array-builder.h"
On 2016/08/11 13:19:15, Michael Starzinger wrote:
> nit: Header file inclusion is obsolete. Lets drop it.

Done.

[rmcilroy, 2016-08-11 14:46:23]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-08-11 14:46:23]

The patchset sent to the CQ was uploaded after l-g-t-m from klaasb@google.com,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2238853002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-11 14:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 15:11:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 15:12:00]

Description was changed from

==========
[Interpreter] Remove LdaConstant+ToName peephole optimization.

This optimization required access to the heap which we can't do off-thread.
There doesn't seem to be a regression without this optmization in anycase,
so just rip it out.

BUG=v8:5203
==========

to

==========
[Interpreter] Remove LdaConstant+ToName peephole optimization.

This optimization required access to the heap which we can't do off-thread.
There doesn't seem to be a regression without this optmization in anycase,
so just rip it out.

BUG=v8:5203

Committed: https://crrev.com/cda8387c89956609789f9b811836bb0714e9da93
Cr-Commit-Position: refs/heads/master@{#38585}
==========

[commit-bot: I haz the power, 2016-08-11 15:12:01]

Patchset 2 (id:??) landed as
https://crrev.com/cda8387c89956609789f9b811836bb0714e9da93
Cr-Commit-Position: refs/heads/master@{#38585}