Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2240463002:
[Interpreter] Introduce InterpreterCompilationJob (Closed)
Description[Interpreter] Introduce InterpreterCompilationJob
Adds InterpreterCompilationJob as a sub-class of
CompilationJob, to enable off-thread bytecode
generation. Currently only used in
Interpreter::MakeBytecode.
As part of this change, CompilationJob is modified
to make it less specific to optimized compilation,
renaming the phases as follows:
- CreateGraph -> PrepareJob
- OptimizeGraph -> ExecuteJob
- GenerateCode -> FinalizeJob
RegisterWeakObjectsInOptimizedCode is also moved out
of CompilationJob and instead becomes a static function
on Compiler.
BUG=v8:5203
Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc
Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9
Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73
Committed: https://crrev.com/0996cea5b6bda4de260ab44ae67c0dd10e091a6b
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#38662}
Cr-Original-Original-Commit-Position: refs/heads/master@{#38668}
Cr-Original-Commit-Position: refs/heads/master@{#38725}
Cr-Commit-Position: refs/heads/master@{#38778}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Subclass Compiler::CompilationTask #Patch Set 4 : DISALLOW_COPY_AND_ASSIGN #
Total comments: 8
Patch Set 5 : Rebase #Patch Set 6 : Address comments #
Total comments: 2
Patch Set 7 : BASE_EMBEDDED #Patch Set 8 : Rebase and tweak #Patch Set 9 : Rebase #
Dependent Patchsets: Messages
Total messages: 62 (34 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rmcilroy@chromium.org changed reviewers: + mstarzinger@chromium.org
Michi, PTAL, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/11 14:53:26, rmcilroy wrote: > Michi, PTAL, thanks. Actually, don't review this yet, I'll probably rework Compiler::CompilationJob to be non-optimization specific and then have this class extend that one - does that sounds reasonable?
On 2016/08/11 15:17:13, rmcilroy wrote: > On 2016/08/11 14:53:26, rmcilroy wrote: > > Michi, PTAL, thanks. > > Actually, don't review this yet, I'll probably rework Compiler::CompilationJob > to be non-optimization specific and then have this class extend that one - does > that sounds reasonable? SGTM. It should already be pretty independent of optimization specifics. The one big thing missing is a renaming of the three phases. The following is the renaming I had in mind, but never got around to actually do (/me too lazy): - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob
On 2016/08/11 15:38:59, Michael Starzinger wrote: > On 2016/08/11 15:17:13, rmcilroy wrote: > > On 2016/08/11 14:53:26, rmcilroy wrote: > > > Michi, PTAL, thanks. > > > > Actually, don't review this yet, I'll probably rework Compiler::CompilationJob > > to be non-optimization specific and then have this class extend that one - > does > > that sounds reasonable? > > SGTM. It should already be pretty independent of optimization specifics. The one > big thing missing is a renaming of the three phases. The following is the > renaming I had in mind, but never got around to actually do (/me too lazy): > > - CreateGraph -> PrepareJob > - OptimizeGraph -> ExecuteJob > - GenerateCode -> FinalizeJob SGTM
Description was changed from ========== [Interpreter] Introduce Interpreter::CompilationJob Adds Interpreter::CompilationJob to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. BUG=v8:5203 ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 ==========
Patchset #3 (id:40001) has been deleted
rmcilroy@chromium.org changed reviewers: + bmeurer@chromium.org
+Benedikt for changes in crankshaft/ Michi: Changed to subclass CompilationJob as discussed, PTAL.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Looking good. I like it. Just two comments (plus nits). https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode124 src/compiler.h:124: static void RegisterWeakObjectsInOptimizedCode(Handle<Code> code); IMHO this doesn't belong into the "Compiler" interface either. It should actually be part of the code generation and is only in compiler.cc in order to be shared between Crankshaft and TurboFan. Can we move it back onto the CompilationJob for now. We can even copy the TODO from the implementation out into interface to clarify that this is a temporary workaround ... // TODO(turbofan): Move this to pipeline.cc once Crankshaft dies. https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode568 src/compiler.h:568: // Executes the compile job. Can called off the main thread. nit: s/Can called/Can be called/ https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode613 src/compiler.h:613: if (status == SUCCEEDED) nit: Curly braces around bodies of multi-line if statements. https://codereview.chromium.org/2240463002/diff/80001/src/interpreter/interpr... File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/2240463002/diff/80001/src/interpreter/interpr... src/interpreter/interpreter.cc:45: std::unique_ptr<BytecodeGenerator> generator_; Would it be possible to just have BytecodeGenerator be an embedded object within the InterpreterCompilationJob instead?
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rmcilroy@chromium.org changed reviewers: + jkummerow@chromium.org - bmeurer@chromium.org
+Jakob for trivial Crankshaft change https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode124 src/compiler.h:124: static void RegisterWeakObjectsInOptimizedCode(Handle<Code> code); On 2016/08/16 08:46:40, Michael Starzinger wrote: > IMHO this doesn't belong into the "Compiler" interface either. It should > actually be part of the code generation and is only in compiler.cc in order to > be shared between Crankshaft and TurboFan. Can we move it back onto the > CompilationJob for now. We can even copy the TODO from the implementation out > into interface to clarify that this is a temporary workaround ... > > // TODO(turbofan): Move this to pipeline.cc once Crankshaft dies. Done. https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode568 src/compiler.h:568: // Executes the compile job. Can called off the main thread. On 2016/08/16 08:46:40, Michael Starzinger wrote: > nit: s/Can called/Can be called/ Done. https://codereview.chromium.org/2240463002/diff/80001/src/compiler.h#newcode613 src/compiler.h:613: if (status == SUCCEEDED) On 2016/08/16 08:46:40, Michael Starzinger wrote: > nit: Curly braces around bodies of multi-line if statements. Done. https://codereview.chromium.org/2240463002/diff/80001/src/interpreter/interpr... File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/2240463002/diff/80001/src/interpreter/interpr... src/interpreter/interpreter.cc:45: std::unique_ptr<BytecodeGenerator> generator_; On 2016/08/16 08:46:40, Michael Starzinger wrote: > Would it be possible to just have BytecodeGenerator be an embedded object within > the InterpreterCompilationJob instead? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Thanks! https://codereview.chromium.org/2240463002/diff/120001/src/ast/ast.h File src/ast/ast.h (left): https://codereview.chromium.org/2240463002/diff/120001/src/ast/ast.h#oldcode2849 src/ast/ast.h:2849: class AstVisitor BASE_EMBEDDED { nit: Can this be kept BASE_EMBEDDED now that we no longer malloc the BytecodeGenerator?
https://codereview.chromium.org/2240463002/diff/120001/src/ast/ast.h File src/ast/ast.h (left): https://codereview.chromium.org/2240463002/diff/120001/src/ast/ast.h#oldcode2849 src/ast/ast.h:2849: class AstVisitor BASE_EMBEDDED { On 2016/08/16 12:11:44, Michael Starzinger wrote: > nit: Can this be kept BASE_EMBEDDED now that we no longer malloc the > BytecodeGenerator? Done.
Trivial crankshaft changes LGTM.
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2240463002/#ps140001 (title: "BASE_EMBEDDED")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:140001) has been created in https://codereview.chromium.org/2249153002/ by rmcilroy@chromium.org. The reason for reverting is: Failing on Win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12061/steps....
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ==========
On 2016/08/16 15:06:14, rmcilroy wrote: > A revert of this CL (patchset #7 id:140001) has been created in > https://codereview.chromium.org/2249153002/ by mailto:rmcilroy@chromium.org. > > The reason for reverting is: Failing on Win64 bot: > https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12061/steps.... Can't repo the failure either on a local windows machine or the trybots. Going to try and reland and see if it was a flake.
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ==========
Message was sent while issue was closed.
Committed patchset #7 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Cr-Commit-Position: refs/heads/master@{#38662} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Commit-Position: refs/heads/master@{#38668}
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:140001) has been created in https://codereview.chromium.org/2251673003/ by rmcilroy@chromium.org. The reason for reverting is: Breaks Win64 bot.
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:140001) has been created in https://codereview.chromium.org/2253713002/ by rmcilroy@chromium.org. The reason for reverting is: Still vreaks Win64 bot :(.
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ==========
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org, jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/2240463002/#ps180001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ==========
Message was sent while issue was closed.
Committed patchset #9 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Cr-Original-Commit-Position: refs/heads/master@{#38662} Cr-Commit-Position: refs/heads/master@{#38668} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Commit-Position: refs/heads/master@{#38725}
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:180001) has been created in https://codereview.chromium.org/2260583002/ by rmcilroy@chromium.org. The reason for reverting is: Revert again....
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ==========
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rmcilroy@chromium.org
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ==========
Message was sent while issue was closed.
Committed patchset #9 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Commit-Position: refs/heads/master@{#38668} Cr-Commit-Position: refs/heads/master@{#38725} ========== to ========== [Interpreter] Introduce InterpreterCompilationJob Adds InterpreterCompilationJob as a sub-class of CompilationJob, to enable off-thread bytecode generation. Currently only used in Interpreter::MakeBytecode. As part of this change, CompilationJob is modified to make it less specific to optimized compilation, renaming the phases as follows: - CreateGraph -> PrepareJob - OptimizeGraph -> ExecuteJob - GenerateCode -> FinalizeJob RegisterWeakObjectsInOptimizedCode is also moved out of CompilationJob and instead becomes a static function on Compiler. BUG=v8:5203 Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 Committed: https://crrev.com/0996cea5b6bda4de260ab44ae67c0dd10e091a6b Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#38662} Cr-Original-Original-Commit-Position: refs/heads/master@{#38668} Cr-Original-Commit-Position: refs/heads/master@{#38725} Cr-Commit-Position: refs/heads/master@{#38778} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/0996cea5b6bda4de260ab44ae67c0dd10e091a6b Cr-Commit-Position: refs/heads/master@{#38778} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
