test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden - Issue 2238853002: [Interpreter] Remove LdaConstant+ToName peephole optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

Issue 2238853002: [Interpreter] Remove LdaConstant+ToName peephole optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_internalize

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

index 8bd8d79cedabe255e3460333cc08d31810120cec..fdfb9b68eb467a547a22bff0d2efbfd329fd6666 100644

--- a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

@@ -404,7 +404,7 @@ bytecodes: [

B(Mov), R(1), R(2),

B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),

B(LdaConstant), U8(3),

- B(Star), R(3),

+ B(ToName), R(3),

B(CreateClosure), U8(4), U8(2),

B(Star), R(4),

B(LdaZero),

@@ -412,7 +412,7 @@ bytecodes: [