test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden - Issue 2238853002: [Interpreter] Remove LdaConstant+ToName peephole optimization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

Issue 2238853002: [Interpreter] Remove LdaConstant+ToName peephole optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_internalize

Patch Set: Address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #	1 #

2 # Autogenerated by generate-bytecode-expectations.	2 # Autogenerated by generate-bytecode-expectations.

3 #	3 #

4	4

5 ---	5 ---

6 pool type: mixed	6 pool type: mixed

7 execute: yes	7 execute: yes

8 wrap: yes	8 wrap: yes

9	9

10 ---	10 ---

(...skipping 386 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
397 /* 60 E> */ B(ToName), R(3),	397 /* 60 E> */ B(ToName), R(3),

398 B(LdaConstant), U8(2),	398 B(LdaConstant), U8(2),

399 B(Star), R(4),	399 B(Star), R(4),

400 B(LdaZero),	400 B(LdaZero),

401 B(Star), R(5),	401 B(Star), R(5),

402 B(LdaZero),	402 B(LdaZero),

403 B(Star), R(6),	403 B(Star), R(6),

404 B(Mov), R(1), R(2),	404 B(Mov), R(1), R(2),

405 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2) , U8(5),	405 B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2) , U8(5),

406 B(LdaConstant), U8(3),	406 B(LdaConstant), U8(3),

407 B(Star), R(3),	407 B(ToName), R(3),

408 B(CreateClosure), U8(4), U8(2),	408 B(CreateClosure), U8(4), U8(2),

409 B(Star), R(4),	409 B(Star), R(4),

410 B(LdaZero),	410 B(LdaZero),

411 B(Star), R(5),	411 B(Star), R(5),

412 B(Mov), R(1), R(2),	412 B(Mov), R(1), R(2),

413 B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), R( 2), U8(4),	413 B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), R( 2), U8(4),

414 B(LdaConstant), U8(3),	414 B(LdaConstant), U8(3),

415 B(Star), R(3),	415 B(ToName), R(3),

416 B(CreateClosure), U8(5), U8(2),	416 B(CreateClosure), U8(5), U8(2),

417 B(Star), R(4),	417 B(Star), R(4),

418 B(LdaZero),	418 B(LdaZero),

419 B(Star), R(5),	419 B(Star), R(5),

420 B(Mov), R(1), R(2),	420 B(Mov), R(1), R(2),

421 B(CallRuntime), U16(Runtime::kDefineSetterPropertyUnchecked), R( 2), U8(4),	421 B(CallRuntime), U16(Runtime::kDefineSetterPropertyUnchecked), R( 2), U8(4),

422 B(Ldar), R(1),	422 B(Ldar), R(1),

423 /* 99 S> */ B(Return),	423 /* 99 S> */ B(Return),

424 ]	424 ]

425 constant pool: [	425 constant pool: [

426 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,	426 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,

427 InstanceType::FIXED_ARRAY_TYPE,	427 InstanceType::FIXED_ARRAY_TYPE,

428 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,	428 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,

429 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,	429 InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,

430 InstanceType::SHARED_FUNCTION_INFO_TYPE,	430 InstanceType::SHARED_FUNCTION_INFO_TYPE,

431 InstanceType::SHARED_FUNCTION_INFO_TYPE,	431 InstanceType::SHARED_FUNCTION_INFO_TYPE,

432 ]	432 ]

433 handlers: [	433 handlers: [

434 ]	434 ]

435	435

OLD	NEW