Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2237143002: Fix a test failure on jellybean devices (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a test failure on jellybean devices There is test regression on Jellybean devices due to https://codereview.chromium.org/2239453002. BUG=636939 Committed: https://crrev.com/5e00bc4eabb303887156d21d9193e8f5993edb81 Cr-Commit-Position: refs/heads/master@{#411420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL
4 years, 4 months ago (2016-08-11 18:58:49 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-11 20:06:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237143002/1
4 years, 4 months ago (2016-08-11 20:24:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 21:13:54 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 21:16:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e00bc4eabb303887156d21d9193e8f5993edb81
Cr-Commit-Position: refs/heads/master@{#411420}

Powered by Google App Engine
This is Rietveld 408576698