Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2237143002: Fix a test failure on jellybean devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 98052578a9dc9caa1240adc363af4fcd95d8b2df..707c5d1c4b2ff1736080907996ae05e4040e019d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -13,6 +13,7 @@ import android.graphics.Rect;
import android.net.Uri;
import android.os.Build;
import android.os.SystemClock;
+import android.support.v4.view.ViewCompat;
import android.view.ContextMenu;
import android.view.LayoutInflater;
import android.view.Menu;
@@ -764,7 +765,8 @@ public class NewTabPage
@Override
public void destroy() {
assert !mIsDestroyed;
- assert !getView().isAttachedToWindow() : "Destroy called before removed from window";
+ assert !ViewCompat
+ .isAttachedToWindow(getView()) : "Destroy called before removed from window";
if (mIsLoaded && !mTab.isHidden()) recordNTPInteractionTime();
if (mFaviconHelper != null) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698