Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Issue 2239453002: [Android] Make it possible to show Infobar in native pages (Second Try) (Closed)

Created:
4 years, 4 months ago by Ian Wen
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make it possible to show Infobar in native pages (Second try) This CL enables Chrome to show infobar in native pages, especially in the NTP. From now on, Tab.getView() will always return the wrapper that holds both infobar container and the tab's content, which could be a native page or a content view, rendered by blink/compositor. BUG=508307 Previous attempt: https://chromiumcodereview.appspot.com/2224853003/ Reverted in: https://codereview.chromium.org/2232943002 TBR=tedchoc@chromium.org Committed: https://crrev.com/55819696987ee6293c8c475e06a65700343a14fa Cr-Commit-Position: refs/heads/master@{#411156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java View 2 chunks +44 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Ian Wen
PTAL. I changed the invalid assertions in new tab page code.
4 years, 4 months ago (2016-08-10 19:06:52 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-10 21:52:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239453002/1
4 years, 4 months ago (2016-08-10 21:53:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 21:59:11 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 22:03:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55819696987ee6293c8c475e06a65700343a14fa
Cr-Commit-Position: refs/heads/master@{#411156}

Powered by Google App Engine
This is Rietveld 408576698