chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java - Issue 2237143002: Fix a test failure on jellybean devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

Issue 2237143002: Fix a test failure on jellybean devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

index af955af85d5ccdfe8be831ce0a3ee9c44f9cabfe..9177041433c9d5c53a3b9cabc8bf7baed85b57bf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.ntp;

import android.app.Activity;

import android.graphics.Canvas;

+import android.support.v4.view.ViewCompat;

import android.view.LayoutInflater;

import android.view.View;

import android.widget.TextView;

@@ -83,7 +84,8 @@ public class IncognitoNewTabPage implements NativePage, InvalidationAwareThumbna

@Override

public void destroy() {

- assert !getView().isAttachedToWindow() : "Destroy called before removed from window";

+ assert !ViewCompat

+ .isAttachedToWindow(getView()) : "Destroy called before removed from window";

}

@Override

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »