Avoid casting non-content BadMessage codes to content BadMessage codes.

Avoid casting non-content BadMessage codes to content BadMessage codes.

This will result in using the wrong value for UMA data and in crash
dumps, magic signatures, etc, leading to confusing investigations.

BUG=598073
TEST=None

Committed: https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006
Cr-Commit-Position: refs/heads/master@{#411171}

[Charlie Reis, 2016-08-10 21:09:14]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:09:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-08-10 21:09:49]

creis@chromium.org changed reviewers:
+ ananta@chromium.org, jam@chromium.org

[Charlie Reis, 2016-08-10 21:09:50]

Here's a quick fix to avoid the corruption I mentioned in
https://codereview.chromium.org/2222723002/, to avoid reverting that CL.

https://codereview.chromium.org/2236503004/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (left):

https://codereview.chromium.org/2236503004/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:1352: filter_,
static_cast<bad_message::BadMessageReason>(error_code));
This is a bad cast, resulting in a collision with the content version of
BadMessageReason.

https://codereview.chromium.org/2236503004/diff/1/extensions/browser/bad_mess...
File extensions/browser/bad_message.h (right):

https://codereview.chromium.org/2236503004/diff/1/extensions/browser/bad_mess...
extensions/browser/bad_message.h:20: // NOTE: Do not remove or reorder elements
in this list. Add new entries at the
We haven't started using INVALID_ORIGIN yet as long as we land this in the same
canary.  We should remove it before it's too late.

[jam, 2016-08-10 21:11:57]

lgtm, thanks for pointing out the issue and for the fix.

[Charlie Reis, 2016-08-10 21:30:34]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-08-10 21:30:39]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:31:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2016-08-10 21:53:35]

On 2016/08/10 21:11:57, jam wrote:
> lgtm, thanks for pointing out the issue and for the fix.

Thanks for fixing this.

[commit-bot: I haz the power, 2016-08-10 22:46:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-10 22:47:59]

Description was changed from

==========
Avoid casting non-content BadMessage codes to content BadMessage codes.

This will result in using the wrong value for UMA data and in crash
dumps, magic signatures, etc, leading to confusing investigations.

BUG=598073
TEST=None
==========

to

==========
Avoid casting non-content BadMessage codes to content BadMessage codes.

This will result in using the wrong value for UMA data and in crash
dumps, magic signatures, etc, leading to confusing investigations.

BUG=598073
TEST=None

Committed: https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006
Cr-Commit-Position: refs/heads/master@{#411171}
==========

[commit-bot: I haz the power, 2016-08-10 22:48:00]

Patchset 1 (id:??) landed as
https://crrev.com/c09e94d74f6efc174bd88195eee902b4350fc006
Cr-Commit-Position: refs/heads/master@{#411171}