content/browser/loader/resource_dispatcher_host_impl.cc - Issue 2236503004: Avoid casting non-content BadMessage codes to content BadMessage codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2236503004: Avoid casting non-content BadMessage codes to content BadMessage codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc ('k') | extensions/browser/bad_message.h » ('j') | extensions/browser/bad_message.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 9218ffb4fcb1ba39209ce165d9f03810dc933515..b7adcbfb30dc89e2a831a099ee5d80cb272a72ed 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1348,8 +1348,9 @@ void ResourceDispatcherHostImpl::ContinuePendingBeginRequest(

bool continue_request,

int error_code) {

if (!continue_request) {

- bad_message::ReceivedBadMessage(

- filter_, static_cast<bad_message::BadMessageReason>(error_code));

Charlie Reis 2016/08/10 21:09:50 This is a bad cast, resulting in a collision with

+ // TODO(ananta): Find a way to specify the right error code here. Passing

+ // in a non-content error code is not safe.

+ bad_message::ReceivedBadMessage(filter_, bad_message::RDH_ILLEGAL_ORIGIN);

AbortRequestBeforeItStarts(filter_, sync_result, request_id);

return;

}