Avoid casting non-content BadMessage codes to content BadMessage codes.

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <stddef.h>
 
@@ skipping 1330 matching lines @@
 
 void ResourceDispatcherHostImpl::ContinuePendingBeginRequest(
     int request_id,
     const ResourceRequest& request_data,
     IPC::Message* sync_result,  // only valid for sync
     int route_id,
     const net::HttpRequestHeaders& headers,
     bool continue_request,
     int error_code) {
   if (!continue_request) {
-    bad_message::ReceivedBadMessage(
-        filter_, static_cast<bad_message::BadMessageReason>(error_code));

[Charlie Reis, 2016/08/10 21:09:50]

This is a bad cast, resulting in a collision with the content version of
BadMessageReason.

+    // TODO(ananta): Find a way to specify the right error code here.  Passing
+    // in a non-content error code is not safe.
+    bad_message::ReceivedBadMessage(filter_, bad_message::RDH_ILLEGAL_ORIGIN);
     AbortRequestBeforeItStarts(filter_, sync_result, request_id);
     return;
   }
 
   int process_type = filter_->process_type();
   int child_id = filter_->child_id();
 
   bool is_navigation_stream_request =
       IsBrowserSideNavigationEnabled() &&
       IsResourceTypeFrame(request_data.resource_type);
@@ skipping 1321 matching lines @@
         interceptor_info.interceptor.Run(it.name(), it.value(), child_id,
                                          resource_context, callback);
         return PENDING;
       }
     }
   }
   return CONTINUE;
 }
 
 }  // namespace content