Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2236503004: Avoid casting non-content BadMessage codes to content BadMessage codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
index f8f27ec010cfef75f667e6e1104651697b4a0815..2d44b432d98a82a6d8ec31b4db6f0ffa171889e2 100644
--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
@@ -193,7 +193,8 @@ void OnHttpHeaderReceived(const std::string& header,
DCHECK(origin.SchemeIs(extensions::kExtensionScheme));
if (IsIllegalOrigin(resource_context, child_id, origin)) {
- callback.Run(false, bad_message::INVALID_ORIGIN);
+ // TODO(ananta): Find a way to specify the right error code here.
+ callback.Run(false, 0);
} else {
callback.Run(true, 0);
}

Powered by Google App Engine
This is Rietveld 408576698