Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. Separate ConvertTaggedHoleToUndefined and CheckTaggedHole into two separate operators, where the former is pure and just turns into trivial control flow in the EffectControlLinearizer. R=jarin@chromium.org Committed: https://crrev.com/e61bd68ede0a8687ba2c8f59c8483c9ea1e0ce45 Cr-Commit-Position: refs/heads/master@{#38559}

Patch Set 1 #

Patch Set 2 : Introduce appropriate Type::Hole #

Total comments: 2

Patch Set 3 : Address comment #

Patch Set 4 : Fix verify heap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -191 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +29 lines, -13 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 3 chunks +9 lines, -10 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +21 lines, -9 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -12 lines 0 comments Download
M src/compiler/simplified-operator.cc View 5 chunks +80 lines, -123 lines 0 comments Download
M src/compiler/typer.cc View 1 2 chunks +10 lines, -12 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/types.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M src/types.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-10 13:21:30 UTC) #1
Jarin
lgtm
4 years, 4 months ago (2016-08-10 13:31:00 UTC) #4
Michael Starzinger
LGTM (rubber-stamp of "heap" with one nit). https://codereview.chromium.org/2236443004/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2236443004/diff/20001/src/heap/heap.cc#newcode2632 src/heap/heap.cc:2632: factory->NewHeapNumber(bit_cast<double>(kHoleNanInt64)), nit: ...
4 years, 4 months ago (2016-08-10 13:59:37 UTC) #9
Benedikt Meurer
https://codereview.chromium.org/2236443004/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2236443004/diff/20001/src/heap/heap.cc#newcode2632 src/heap/heap.cc:2632: factory->NewHeapNumber(bit_cast<double>(kHoleNanInt64)), On 2016/08/10 13:59:37, Michael Starzinger wrote: > nit: ...
4 years, 4 months ago (2016-08-10 14:01:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236443004/40001
4 years, 4 months ago (2016-08-10 14:01:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10740) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 14:59:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236443004/60001
4 years, 4 months ago (2016-08-10 17:44:20 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-10 19:15:34 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:16:01 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e61bd68ede0a8687ba2c8f59c8483c9ea1e0ce45
Cr-Commit-Position: refs/heads/master@{#38559}

Powered by Google App Engine
This is Rietveld 408576698