src/compiler/verifier.cc - Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix verify heap. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index eabd99dcf479dbb93bc5c2834aac32509a08bf7a..770c97f078f9ac26bc590104721f3be22b8b4d34 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -1042,7 +1042,11 @@ void Verifier::Visitor::Check(Node* node) {

break;

case IrOpcode::kCheckTaggedHole:

CheckValueInputIs(node, 0, Type::Any());

- CheckUpperIs(node, Type::Any());

+ CheckUpperIs(node, Type::NonInternal());

+ break;

+ case IrOpcode::kConvertTaggedHoleToUndefined:

+ CheckValueInputIs(node, 0, Type::Any());

+ CheckUpperIs(node, Type::NonInternal());

break;

case IrOpcode::kLoadField:

« no previous file with comments | « src/compiler/typer.cc ('k') | src/heap/heap.h » ('j') | no next file with comments »