[turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator.

src/compiler/simplified-operator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/simplified-operator.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/types.h"
@@ skipping 211 matching lines @@
   switch (mode) {
     case CheckForMinusZeroMode::kCheckForMinusZero:
       return os << "check-for-minus-zero";
     case CheckForMinusZeroMode::kDontCheckForMinusZero:
       return os << "dont-check-for-minus-zero";
   }
   UNREACHABLE();
   return os;
 }
 
-size_t hash_value(CheckTaggedHoleMode mode) {
-  return static_cast<size_t>(mode);
-}
-
-std::ostream& operator<<(std::ostream& os, CheckTaggedHoleMode mode) {
-  switch (mode) {
-    case CheckTaggedHoleMode::kConvertHoleToUndefined:
-      return os << "convert-hole-to-undefined";
-    case CheckTaggedHoleMode::kNeverReturnHole:
-      return os << "never-return-hole";
-  }
-  UNREACHABLE();
-  return os;
-}
-
-CheckTaggedHoleMode CheckTaggedHoleModeOf(const Operator* op) {
-  DCHECK_EQ(IrOpcode::kCheckTaggedHole, op->opcode());
-  return OpParameter<CheckTaggedHoleMode>(op);
-}
-
 size_t hash_value(CheckTaggedInputMode mode) {
   return static_cast<size_t>(mode);
 }
 
 std::ostream& operator<<(std::ostream& os, CheckTaggedInputMode mode) {
   switch (mode) {
     case CheckTaggedInputMode::kNumber:
       return os << "Number";
     case CheckTaggedInputMode::kNumberOrOddball:
       return os << "NumberOrOddball";
@@ skipping 82 matching lines @@
          op->opcode() == IrOpcode::kSpeculativeNumberShiftRightLogical ||
          op->opcode() == IrOpcode::kSpeculativeNumberBitwiseAnd ||
          op->opcode() == IrOpcode::kSpeculativeNumberBitwiseOr ||
          op->opcode() == IrOpcode::kSpeculativeNumberBitwiseXor ||
          op->opcode() == IrOpcode::kSpeculativeNumberEqual ||
          op->opcode() == IrOpcode::kSpeculativeNumberLessThan ||
          op->opcode() == IrOpcode::kSpeculativeNumberLessThanOrEqual);
   return OpParameter<NumberOperationHint>(op);
 }
 
-#define PURE_OP_LIST(V)                                       \
-  V(BooleanNot, Operator::kNoProperties, 1, 0)                \
-  V(NumberEqual, Operator::kCommutative, 2, 0)                \
-  V(NumberLessThan, Operator::kNoProperties, 2, 0)            \
-  V(NumberLessThanOrEqual, Operator::kNoProperties, 2, 0)     \
-  V(NumberAdd, Operator::kCommutative, 2, 0)                  \
-  V(NumberSubtract, Operator::kNoProperties, 2, 0)            \
-  V(NumberMultiply, Operator::kCommutative, 2, 0)             \
-  V(NumberDivide, Operator::kNoProperties, 2, 0)              \
-  V(NumberModulus, Operator::kNoProperties, 2, 0)             \
-  V(NumberBitwiseOr, Operator::kCommutative, 2, 0)            \
-  V(NumberBitwiseXor, Operator::kCommutative, 2, 0)           \
-  V(NumberBitwiseAnd, Operator::kCommutative, 2, 0)           \
-  V(NumberShiftLeft, Operator::kNoProperties, 2, 0)           \
-  V(NumberShiftRight, Operator::kNoProperties, 2, 0)          \
-  V(NumberShiftRightLogical, Operator::kNoProperties, 2, 0)   \
-  V(NumberImul, Operator::kCommutative, 2, 0)                 \
-  V(NumberAbs, Operator::kNoProperties, 1, 0)                 \
-  V(NumberClz32, Operator::kNoProperties, 1, 0)               \
-  V(NumberCeil, Operator::kNoProperties, 1, 0)                \
-  V(NumberFloor, Operator::kNoProperties, 1, 0)               \
-  V(NumberFround, Operator::kNoProperties, 1, 0)              \
-  V(NumberAcos, Operator::kNoProperties, 1, 0)                \
-  V(NumberAcosh, Operator::kNoProperties, 1, 0)               \
-  V(NumberAsin, Operator::kNoProperties, 1, 0)                \
-  V(NumberAsinh, Operator::kNoProperties, 1, 0)               \
-  V(NumberAtan, Operator::kNoProperties, 1, 0)                \
-  V(NumberAtan2, Operator::kNoProperties, 2, 0)               \
-  V(NumberAtanh, Operator::kNoProperties, 1, 0)               \
-  V(NumberCbrt, Operator::kNoProperties, 1, 0)                \
-  V(NumberCos, Operator::kNoProperties, 1, 0)                 \
-  V(NumberCosh, Operator::kNoProperties, 1, 0)                \
-  V(NumberExp, Operator::kNoProperties, 1, 0)                 \
-  V(NumberExpm1, Operator::kNoProperties, 1, 0)               \
-  V(NumberLog, Operator::kNoProperties, 1, 0)                 \
-  V(NumberLog1p, Operator::kNoProperties, 1, 0)               \
-  V(NumberLog10, Operator::kNoProperties, 1, 0)               \
-  V(NumberLog2, Operator::kNoProperties, 1, 0)                \
-  V(NumberMax, Operator::kNoProperties, 2, 0)                 \
-  V(NumberMin, Operator::kNoProperties, 2, 0)                 \
-  V(NumberPow, Operator::kNoProperties, 2, 0)                 \
-  V(NumberRound, Operator::kNoProperties, 1, 0)               \
-  V(NumberSign, Operator::kNoProperties, 1, 0)                \
-  V(NumberSin, Operator::kNoProperties, 1, 0)                 \
-  V(NumberSinh, Operator::kNoProperties, 1, 0)                \
-  V(NumberSqrt, Operator::kNoProperties, 1, 0)                \
-  V(NumberTan, Operator::kNoProperties, 1, 0)                 \
-  V(NumberTanh, Operator::kNoProperties, 1, 0)                \
-  V(NumberTrunc, Operator::kNoProperties, 1, 0)               \
-  V(NumberToInt32, Operator::kNoProperties, 1, 0)             \
-  V(NumberToUint32, Operator::kNoProperties, 1, 0)            \
-  V(NumberSilenceNaN, Operator::kNoProperties, 1, 0)          \
-  V(StringCharCodeAt, Operator::kNoProperties, 2, 1)          \
-  V(StringFromCharCode, Operator::kNoProperties, 1, 0)        \
-  V(PlainPrimitiveToNumber, Operator::kNoProperties, 1, 0)    \
-  V(PlainPrimitiveToWord32, Operator::kNoProperties, 1, 0)    \
-  V(PlainPrimitiveToFloat64, Operator::kNoProperties, 1, 0)   \
-  V(ChangeTaggedSignedToInt32, Operator::kNoProperties, 1, 0) \
-  V(ChangeTaggedToInt32, Operator::kNoProperties, 1, 0)       \
-  V(ChangeTaggedToUint32, Operator::kNoProperties, 1, 0)      \
-  V(ChangeTaggedToFloat64, Operator::kNoProperties, 1, 0)     \
-  V(ChangeInt31ToTaggedSigned, Operator::kNoProperties, 1, 0) \
-  V(ChangeInt32ToTagged, Operator::kNoProperties, 1, 0)       \
-  V(ChangeUint32ToTagged, Operator::kNoProperties, 1, 0)      \
-  V(ChangeFloat64ToTagged, Operator::kNoProperties, 1, 0)     \
-  V(ChangeTaggedToBit, Operator::kNoProperties, 1, 0)         \
-  V(ChangeBitToTagged, Operator::kNoProperties, 1, 0)         \
-  V(TruncateTaggedToWord32, Operator::kNoProperties, 1, 0)    \
-  V(TruncateTaggedToFloat64, Operator::kNoProperties, 1, 0)   \
-  V(ObjectIsCallable, Operator::kNoProperties, 1, 0)          \
-  V(ObjectIsNumber, Operator::kNoProperties, 1, 0)            \
-  V(ObjectIsReceiver, Operator::kNoProperties, 1, 0)          \
-  V(ObjectIsSmi, Operator::kNoProperties, 1, 0)               \
-  V(ObjectIsString, Operator::kNoProperties, 1, 0)            \
-  V(ObjectIsUndetectable, Operator::kNoProperties, 1, 0)      \
-  V(ReferenceEqual, Operator::kCommutative, 2, 0)             \
-  V(StringEqual, Operator::kCommutative, 2, 0)                \
-  V(StringLessThan, Operator::kNoProperties, 2, 0)            \
+#define PURE_OP_LIST(V)                                          \
+  V(BooleanNot, Operator::kNoProperties, 1, 0)                   \
+  V(NumberEqual, Operator::kCommutative, 2, 0)                   \
+  V(NumberLessThan, Operator::kNoProperties, 2, 0)               \
+  V(NumberLessThanOrEqual, Operator::kNoProperties, 2, 0)        \
+  V(NumberAdd, Operator::kCommutative, 2, 0)                     \
+  V(NumberSubtract, Operator::kNoProperties, 2, 0)               \
+  V(NumberMultiply, Operator::kCommutative, 2, 0)                \
+  V(NumberDivide, Operator::kNoProperties, 2, 0)                 \
+  V(NumberModulus, Operator::kNoProperties, 2, 0)                \
+  V(NumberBitwiseOr, Operator::kCommutative, 2, 0)               \
+  V(NumberBitwiseXor, Operator::kCommutative, 2, 0)              \
+  V(NumberBitwiseAnd, Operator::kCommutative, 2, 0)              \
+  V(NumberShiftLeft, Operator::kNoProperties, 2, 0)              \
+  V(NumberShiftRight, Operator::kNoProperties, 2, 0)             \
+  V(NumberShiftRightLogical, Operator::kNoProperties, 2, 0)      \
+  V(NumberImul, Operator::kCommutative, 2, 0)                    \
+  V(NumberAbs, Operator::kNoProperties, 1, 0)                    \
+  V(NumberClz32, Operator::kNoProperties, 1, 0)                  \
+  V(NumberCeil, Operator::kNoProperties, 1, 0)                   \
+  V(NumberFloor, Operator::kNoProperties, 1, 0)                  \
+  V(NumberFround, Operator::kNoProperties, 1, 0)                 \
+  V(NumberAcos, Operator::kNoProperties, 1, 0)                   \
+  V(NumberAcosh, Operator::kNoProperties, 1, 0)                  \
+  V(NumberAsin, Operator::kNoProperties, 1, 0)                   \
+  V(NumberAsinh, Operator::kNoProperties, 1, 0)                  \
+  V(NumberAtan, Operator::kNoProperties, 1, 0)                   \
+  V(NumberAtan2, Operator::kNoProperties, 2, 0)                  \
+  V(NumberAtanh, Operator::kNoProperties, 1, 0)                  \
+  V(NumberCbrt, Operator::kNoProperties, 1, 0)                   \
+  V(NumberCos, Operator::kNoProperties, 1, 0)                    \
+  V(NumberCosh, Operator::kNoProperties, 1, 0)                   \
+  V(NumberExp, Operator::kNoProperties, 1, 0)                    \
+  V(NumberExpm1, Operator::kNoProperties, 1, 0)                  \
+  V(NumberLog, Operator::kNoProperties, 1, 0)                    \
+  V(NumberLog1p, Operator::kNoProperties, 1, 0)                  \
+  V(NumberLog10, Operator::kNoProperties, 1, 0)                  \
+  V(NumberLog2, Operator::kNoProperties, 1, 0)                   \
+  V(NumberMax, Operator::kNoProperties, 2, 0)                    \
+  V(NumberMin, Operator::kNoProperties, 2, 0)                    \
+  V(NumberPow, Operator::kNoProperties, 2, 0)                    \
+  V(NumberRound, Operator::kNoProperties, 1, 0)                  \
+  V(NumberSign, Operator::kNoProperties, 1, 0)                   \
+  V(NumberSin, Operator::kNoProperties, 1, 0)                    \
+  V(NumberSinh, Operator::kNoProperties, 1, 0)                   \
+  V(NumberSqrt, Operator::kNoProperties, 1, 0)                   \
+  V(NumberTan, Operator::kNoProperties, 1, 0)                    \
+  V(NumberTanh, Operator::kNoProperties, 1, 0)                   \
+  V(NumberTrunc, Operator::kNoProperties, 1, 0)                  \
+  V(NumberToInt32, Operator::kNoProperties, 1, 0)                \
+  V(NumberToUint32, Operator::kNoProperties, 1, 0)               \
+  V(NumberSilenceNaN, Operator::kNoProperties, 1, 0)             \
+  V(StringCharCodeAt, Operator::kNoProperties, 2, 1)             \
+  V(StringFromCharCode, Operator::kNoProperties, 1, 0)           \
+  V(PlainPrimitiveToNumber, Operator::kNoProperties, 1, 0)       \
+  V(PlainPrimitiveToWord32, Operator::kNoProperties, 1, 0)       \
+  V(PlainPrimitiveToFloat64, Operator::kNoProperties, 1, 0)      \
+  V(ChangeTaggedSignedToInt32, Operator::kNoProperties, 1, 0)    \
+  V(ChangeTaggedToInt32, Operator::kNoProperties, 1, 0)          \
+  V(ChangeTaggedToUint32, Operator::kNoProperties, 1, 0)         \
+  V(ChangeTaggedToFloat64, Operator::kNoProperties, 1, 0)        \
+  V(ChangeInt31ToTaggedSigned, Operator::kNoProperties, 1, 0)    \
+  V(ChangeInt32ToTagged, Operator::kNoProperties, 1, 0)          \
+  V(ChangeUint32ToTagged, Operator::kNoProperties, 1, 0)         \
+  V(ChangeFloat64ToTagged, Operator::kNoProperties, 1, 0)        \
+  V(ChangeTaggedToBit, Operator::kNoProperties, 1, 0)            \
+  V(ChangeBitToTagged, Operator::kNoProperties, 1, 0)            \
+  V(TruncateTaggedToWord32, Operator::kNoProperties, 1, 0)       \
+  V(TruncateTaggedToFloat64, Operator::kNoProperties, 1, 0)      \
+  V(ObjectIsCallable, Operator::kNoProperties, 1, 0)             \
+  V(ObjectIsNumber, Operator::kNoProperties, 1, 0)               \
+  V(ObjectIsReceiver, Operator::kNoProperties, 1, 0)             \
+  V(ObjectIsSmi, Operator::kNoProperties, 1, 0)                  \
+  V(ObjectIsString, Operator::kNoProperties, 1, 0)               \
+  V(ObjectIsUndetectable, Operator::kNoProperties, 1, 0)         \
+  V(ConvertTaggedHoleToUndefined, Operator::kNoProperties, 1, 0) \
+  V(ReferenceEqual, Operator::kCommutative, 2, 0)                \
+  V(StringEqual, Operator::kCommutative, 2, 0)                   \
+  V(StringLessThan, Operator::kNoProperties, 2, 0)               \
   V(StringLessThanOrEqual, Operator::kNoProperties, 2, 0)
 
 #define SPECULATIVE_NUMBER_BINOP_LIST(V)      \
   SIMPLIFIED_SPECULATIVE_NUMBER_BINOP_LIST(V) \
   V(SpeculativeNumberEqual)                   \
   V(SpeculativeNumberLessThan)                \
   V(SpeculativeNumberLessThanOrEqual)
 
 #define CHECKED_OP_LIST(V)            \
   V(CheckBounds, 2, 1)                \
   V(CheckIf, 1, 0)                    \
   V(CheckNumber, 1, 1)                \
   V(CheckString, 1, 1)                \
+  V(CheckTaggedHole, 1, 1)            \
   V(CheckTaggedPointer, 1, 1)         \
   V(CheckTaggedSigned, 1, 1)          \
   V(CheckedInt32Add, 2, 1)            \
   V(CheckedInt32Sub, 2, 1)            \
   V(CheckedInt32Div, 2, 1)            \
   V(CheckedInt32Mod, 2, 1)            \
   V(CheckedUint32Div, 2, 1)           \
   V(CheckedUint32Mod, 2, 1)           \
   V(CheckedUint32ToInt32, 1, 1)       \
   V(CheckedTaggedSignedToInt32, 1, 1) \
@@ skipping 84 matching lines @@
         : Operator1<CheckFloat64HoleMode>(
               IrOpcode::kCheckFloat64Hole,
               Operator::kFoldable | Operator::kNoThrow, "CheckFloat64Hole", 1,
               1, 1, 1, 1, 0, kMode) {}
   };
   CheckFloat64HoleNaNOperator<CheckFloat64HoleMode::kAllowReturnHole>
       kCheckFloat64HoleAllowReturnHoleOperator;
   CheckFloat64HoleNaNOperator<CheckFloat64HoleMode::kNeverReturnHole>
       kCheckFloat64HoleNeverReturnHoleOperator;
 
-  template <CheckTaggedHoleMode kMode>
-  struct CheckTaggedHoleOperator final : public Operator1<CheckTaggedHoleMode> {
-    CheckTaggedHoleOperator()
-        : Operator1<CheckTaggedHoleMode>(
-              IrOpcode::kCheckTaggedHole,
-              Operator::kFoldable | Operator::kNoThrow, "CheckTaggedHole", 1, 1,
-              1, 1, 1, 0, kMode) {}
-  };
-  CheckTaggedHoleOperator<CheckTaggedHoleMode::kConvertHoleToUndefined>
-      kCheckTaggedHoleConvertHoleToUndefinedOperator;
-  CheckTaggedHoleOperator<CheckTaggedHoleMode::kNeverReturnHole>
-      kCheckTaggedHoleNeverReturnHoleOperator;
-
   template <PretenureFlag kPretenure>
   struct AllocateOperator final : public Operator1<PretenureFlag> {
     AllocateOperator()
         : Operator1<PretenureFlag>(
               IrOpcode::kAllocate,
               Operator::kNoDeopt | Operator::kNoThrow | Operator::kNoWrite,
               "Allocate", 1, 1, 1, 1, 1, 0, kPretenure) {}
   };
   AllocateOperator<NOT_TENURED> kAllocateNotTenuredOperator;
   AllocateOperator<TENURED> kAllocateTenuredOperator;
@@ skipping 127 matching lines @@
   switch (mode) {
     case CheckFloat64HoleMode::kAllowReturnHole:
       return &cache_.kCheckFloat64HoleAllowReturnHoleOperator;
     case CheckFloat64HoleMode::kNeverReturnHole:
       return &cache_.kCheckFloat64HoleNeverReturnHoleOperator;
   }
   UNREACHABLE();
   return nullptr;
 }
 
-const Operator* SimplifiedOperatorBuilder::CheckTaggedHole(
-    CheckTaggedHoleMode mode) {
-  switch (mode) {
-    case CheckTaggedHoleMode::kConvertHoleToUndefined:
-      return &cache_.kCheckTaggedHoleConvertHoleToUndefinedOperator;
-    case CheckTaggedHoleMode::kNeverReturnHole:
-      return &cache_.kCheckTaggedHoleNeverReturnHoleOperator;
-  }
-  UNREACHABLE();
-  return nullptr;
-}
-
 const Operator* SimplifiedOperatorBuilder::EnsureWritableFastElements() {
   return &cache_.kEnsureWritableFastElements;
 }
 
 const Operator* SimplifiedOperatorBuilder::MaybeGrowFastElements(
     GrowFastElementsFlags flags) {
   return new (zone()) Operator1<GrowFastElementsFlags>(  // --
       IrOpcode::kMaybeGrowFastElements,                  // opcode
       Operator::kNoThrow,                                // flags
       "MaybeGrowFastElements",                           // name
@@ skipping 82 matching lines @@
                         Operator::kNoDeopt | Operator::kNoThrow | properties,  \
                         #Name, value_input_count, 1, control_input_count,      \
                         output_count, 1, 0, access);                           \
   }
 ACCESS_OP_LIST(ACCESS)
 #undef ACCESS
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8